-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Split observer events #20151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tim-blackbird
wants to merge
18
commits into
bevyengine:main
Choose a base branch
from
tim-blackbird:split-observer-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+227
−191
Open
Split observer events #20151
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4d82820
Split new `BroadcastEvent` trait from `Event`
tim-blackbird 9154556
docs fixes
tim-blackbird bd812cd
Make `BroadcastEvent` and `EntityEvent` mutually exclusive
tim-blackbird d80e61b
Adjust docs and target getters of `On` and `ObserverTrigger`
tim-blackbird 2623515
Adjust release note
tim-blackbird 8035f60
Temporarily disable targetless `SceneInstanceReady` event
tim-blackbird 060c183
Hide associated type `Kind` as implementation detail
tim-blackbird 779e453
Update event_split.md
tim-blackbird 1161216
Revert changes related mutual exclusivity + minor docs and release no…
tim-blackbird 15ffea3
docs!
tim-blackbird d7b7631
Fix markdown errors
tim-blackbird e50a4d7
More documentation work
tim-blackbird 42232dd
missed rename
tim-blackbird 1b1283a
Revert some unnecessary changes
tim-blackbird 21602ea
Moar doc fixes
tim-blackbird f17ecc8
Add `observer_no_target` test back
tim-blackbird 1a0191f
Undo newline in lib.rs
tim-blackbird 77bc7a5
Merge branch 'main' into split-observer-events
tim-blackbird File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excellent docs!