fix: Update column definitions that do not match column contents #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmikkelsen
approved these changes
Sep 2, 2025
|
This can be improved in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on improving column validation in the validator, we decided that failure to match declared column values should be an error, not a warning (bids-standard/bids-validator#247). This produces errors in a couple examples, so this PR fixes those examples.
@arnodelorme You are listed as the maintainer of eeg_rishikesh
@markmikkelsen You are listed as the maintainer of mrs_fmrs
Would you mind reviewing these changes?