Skip to content

[ENH] Accept UTC offsets in datetimes #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

effigies
Copy link
Collaborator

As discussed in #1968, non-UTC timezones can be useful for coordinating acquisitions across time zones. The spec currently adopts RFC3339 with the exception that nonzero UTC offsets are not permitted, and the Z offset is optional to allow indicating local time.

For backwards compatibility, I propose allowing the offsets to remain optional, but permitting the full range of RFC3339 offsets.

Separately, the current regular expression does not express the current rule, so I will open another PR against the maintenance branch for that.

Copy link
Member

@nellh nellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the structure of the regular expression and this looks good to me.

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (3b6d2f7) to head (2fc3090).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2001   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files          17       17           
  Lines        1499     1499           
=======================================
  Hits         1238     1238           
  Misses        261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants