[ENH] Define "phenotype" as a data type not nested inside subjects #2050
Conversation
|
attn @bids-standard/bep036 |
effigies
force-pushed
the
feat/phenotype-datatype
branch
from
f64abd7 to
d85831e
Compare
effigies
force-pushed
the
feat/phenotype-datatype
branch
from
d85831e to
f5a4863
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2050 +/- ##
==========================================
+ Coverage 82.65% 82.71% +0.05%
==========================================
Files 17 17
Lines 1534 1533 -1
==========================================
Hits 1268 1268
+ Misses 266 265 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
force-pushed
the
feat/phenotype-datatype
branch
from
f5a4863 to
b9e272a
Compare
|
@yarikoptic @ericearl @surchs I believe that this and the issue (#1828) have had enough time to garner negative comments, so I would like to proceed by consensus. I think this would be a useful addition for consistency within the schema and would appreciate a review. |
| @@ -44,6 +43,11 @@ data_type: | |||
|
|
|||
| 14. `mrs` (magnetic resonance spectroscopy) | |||
|
|
|||
| 15. `phenotype` (participant-level measurement and survey data) | |||
There was a problem hiding this comment.
so it would be coming under a session folder if it is a dataset where there is a session folder for a subject, right? so it would not be "participant-level" but "session-level"? then I would just KISS:
| 15. `phenotype` (participant-level measurement and survey data) | |
| 15. `phenotype` (measurement and survey data) |
There was a problem hiding this comment.
No, the whole idea is that this doesn't change the meaning of phenotype, it slightly broadens the notion of datatype. This does not permit phenotype directories in sessions.
There was a problem hiding this comment.
but they are becoming (or already?) allowed at subject level so I could have sub-1/phenotype/ in addition to e.g. sub-1/ses-1? if not, then it is still located at "dataset level" (as in https://bids-specification.readthedocs.io/en/stable/modality-agnostic-files.html#phenotypic-and-assessment-data) and "participant-level" is confusing here... then
| 15. `phenotype` (participant-level measurement and survey data) | |
| 15. `phenotype` (participant-level measurement and survey data at dataset level phenotype/) |
or alike to clear it up?
| 15. `phenotype` (measurement and survey data) | ||
|
|
||
| For files that are subject- and session- specific, the data type directory | ||
| is nested inside those directories. | ||
| `phenotype` data files are aggregated across subjects and sessions, | ||
| and so the `phenotype/` directory is placed in the dataset root. |
There was a problem hiding this comment.
@yarikoptic @ericearl Hopefully this is clearer.
Closes #1828. Please continue the conversation in that issue, and reserve this PR for discussing concrete changes.