-
Notifications
You must be signed in to change notification settings - Fork 177
[MAINT] use jinja in the macros #2083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated: could be extracted in separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated: could be extracted in separate PR
descriptions are back in pdf and still there in html: |
or similarly: |
I believe this is not a bug - we need to remove the indentation from the common principles yaml (it was added precisely because the current parser would otherwise render something funky). bids-specification/src/schema/objects/common_principles.yaml Lines 11 to 48 in 7f5e0a7
|
ha yeah good catch! |
will probably focus refactoring by getting macros to use jinja first with 'no change in behavior' and then tackle remaining 'bugs' in a follow up PRs also I would not mind have more explicit tests for some of this because working on this feels like flying blind. |
this is just a test to see if using jinja templates in the macros could help with our rendering of HTML / PDF