-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Start loading contexts earlier, buffer contexts for better concurrency #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 87.32% 87.35% +0.03%
==========================================
Files 49 50 +1
Lines 3620 3662 +42
Branches 593 600 +7
==========================================
+ Hits 3161 3199 +38
- Misses 449 453 +4
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Forgot to run tests... Just validated. |
5faa36b
to
b352770
Compare
b352770
to
f29ef84
Compare
f29ef84
to
af40a38
Compare
af40a38
to
2b0e288
Compare
2b0e288
to
ac133ef
Compare
Okay, reworked this to perform |
This PR has two pieces, neither of which produce any noticeable speedup on their own. The first creates a
context.loaded
Promise that indicates whether the context is fully loaded. The second creates a queue that can hold onto initializing contexts until we're ready for them.For ds000001, I was getting about 9s per run. With a queue of 5, down to 4s, and a queue of 20 got us down to 2s.