285 remove closures en codim2 continuation and periodic orbits#289
Open
285 remove closures en codim2 continuation and periodic orbits#289
Conversation
…nuationState, contRes) this allows to dispatch on it
… dispatch for record_from_solution(iter, state)
refactor Problems.jl the constructor of AbstractMABifurcationProblem put missing for the parameters by default
use Val{} in potrap_scheme! for parameters
…nuation. This is useful for example in case of mesh adaptation.
…a discretization, not a problem change jacobian(prob::AbstractWrapperPeriodicOrbitProblem,....
…periodic orbits refactor add Chenciner bifurcation point
refactor update!(wrap::WrapPOColl
…nState) to allow disptach
…ented into Fold/Hopf/PeriodDoubling/NeimarkSackerMinimallyAugmentedFormulation refactor
This commit handles the update (section, mesh adaptation) of periodic orbit functionals. It removes the bad use of closures in this context
…Iterable{FoldPeriodicOrbitCont}...
correct mistake jad for jacobian_adjoint in MinAugFold.jl correct tests
add method get_parameter(x, 𝐏𝐛::AbstractMinimallyAugmentedFormulation) correct some remaining old methods vf(...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to solve issue 285.
This requires a lot of refactor, see
News.md.This simplifies a lot the handling of curves of bifurcations of periodic orbits.
The generality of
src/codim2, now refactored should ease the implementation of Discrete Problems as inMatcontM.