Skip to content

Separate services for pre- and post-upload #8

@oeway

Description

@oeway

I am thinking whether it make sense to create a more integrated services for the following:

A uploader service with the following functions:

  • new_upload(type='model', id='affable-shark'): this will interact with s3-client service, and generate URL, if id is set, then it means a new version, if id is not set then we will generate one for it. the return should be a presigned upload URL and version etc.
  • finish_upload(id='affable-shark', version='3'): calling this will notify the CI, and other things.
  • check_status(id='affable-shark', version='3'): return the status of the model, all the actions along with all the chat messages.

A reviewer service with the following funtions:

  • list_versions(id): list all the chat messages
  • new_message(id, version, message): for append a chat message
  • get_messages(id, version): get the chat messages of a version
  • request_changes(id, version): request changes for a staged version
  • approve(id, version): approve a staged version
  • test_model(id, version): run test with the test dataset for a staged version, this will be implemented with hypha-launcher, it will return either it success or not, and the logs.

One of the motivation for separating this services is to simplify clients that only upload, and the review services will only be used by us internally. With the 'uploader' service above, we will be able to support CLI, and rust clients, easily with a clean interface.

Did I miss anything? What do you think?

cc @jmetz @FynnBe

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions