Skip to content

Conversation

scottclowe
Copy link
Member

Adjust the default readthedocs theme so the colours match @annavik's style guide for bioscan-browser.

Before:
image

After:
image

Thanks to @annavik for proposing this, and refining the stylesheet to use.

@scottclowe scottclowe requested a review from annavik February 7, 2025 07:57
@scottclowe
Copy link
Member Author

I'll merge this in and we can make any further updates if necessary in a new PR.

@scottclowe
Copy link
Member Author

Actually, before I merge it in, you can check out the build here: https://bioscan-dataset.readthedocs.io/en/doc_new-color-scheme/

@annavik
Copy link
Member

annavik commented Mar 14, 2025

Thanks for your patience on this Scott! I had a look, I think it's looking good 👌

I pushed 2 small updates:

  • Tweak source link color (to match other links)
  • Update version select appearance (to give it some better contrast and similar style to other buttons)

From my side, I think we can merge this now!

@scottclowe
Copy link
Member Author

Great, thanks Anna! Agreed - I also thought the contrast was too low on select when it was rendered. I'll merge it in now.

@scottclowe scottclowe merged commit 511c382 into master Mar 14, 2025
5 checks passed
@scottclowe scottclowe deleted the doc_new-color-scheme branch March 21, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants