BUG: Support mapping NaN -> -1 in label2index #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to support this because the value returned by the dataset for missing values in all categorical columns is NaN, even for columns that contain taxonomic strings.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the label2index function by mapping missing values (either empty strings or NaN values) to -1, ensuring consistent handling of missing categorical labels.
- Update docstrings to describe the new behavior.
- Modify conditionals to check for NaN values using pandas.isna in both bioscan5m.py and bioscan1m.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bioscan_dataset/bioscan5m.py | Updated label2index to map NaN values to -1 |
| bioscan_dataset/bioscan1m.py | Updated label2index to map NaN values to -1 |
Comments suppressed due to low confidence (2)
bioscan_dataset/bioscan5m.py:615
- Consider adding unit tests to verify that NaN values are correctly mapped to -1 in label2index.
Entries containing missing values, indicated by empty strings or NaN values,
bioscan_dataset/bioscan1m.py:894
- Consider adding tests to confirm the NaN mapping behavior to -1 in label2index.
Entries containing missing values, indicated by empty strings or NaN values,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to support this because the value returned by the dataset for missing values in all categorical columns is NaN, even for columns that contain taxonomic strings.