fix(layout): broken mobile margins on release page #1174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On mobile screen sizes, inline codes inside of
downloadkeys
and each of the OS verification instructions are overflowing and breaking the right page margin causing the entire page's width to increase on mobile screen sizes and become scrollable; this also breaks the header and footer. The OS instructions currently break the page margin only whendetails
is opened to reveal its content.Rather than edit global behaviors for inline code to wrap down or become scrollable on overflow, the simplest solution is to just replace them with fenced code blocks; most of the other code blocks there are already that type anyway so it appears more consistent. The inline code for
downloadkeys
when replaced with a fenced code block apparently would not become scrollable despite applying different several techniques including with inline styling, so ultimately I opted to make that particular code block just wrap down.This fix will:
details
with scrollable fenced code blocks.downloadkeys
inline code with a fenced code block that wraps down (since horizontal scroll proved unreliable).No global styling changes are made
Tested the fix with Chrome and Firefox on desktop and mobile app versions; the page now behaves as expected.
Before -

downloadkeys
- 400px screen sizeAfter -

downloadkeys
- 400px screen sizeBefore - Instructions

After - Instructions
