qml, refactoring: Separate guiconstants from QT

Separating guiconstants.h file from QT, copying it from src/qt to src/qml
and updating QAPP_APP_NAME_* constants values so both QT and QML gui apps
don't clash with each other trying to persist same or different settings
(e.g. configuration file for QT on signet will be still named as
Bitcoin-Qt-signet.conf, as of today, while QML will start using a separate
file named Bitcoin-Qml-signet.conf).

This could be a temporary fix so instances from both QT and QML gui apps
don't interfere between them during QML development. This change will be
transparent for both QT app and users.

Author: pablomartin4btc

src/Makefile.qt.include

@@ -123,6 +123,7 @@ BITCOIN_QT_H = \
   qml/models/peerlistsortproxy.h \
   qml/appmode.h \
   qml/bitcoin.h \
+  qml/guiconstants.h \
   qml/imageprovider.h \
   qml/util.h \
   qt/addressbookpage.h \
@@ -140,7 +141,6 @@ BITCOIN_QT_H = \
   qt/createwalletdialog.h \
   qt/csvmodelwriter.h \
   qt/editaddressdialog.h \
-  qt/guiconstants.h \
   qt/guiutil.h \
   qt/initexecutor.h \
   qt/intro.h \

src/qml/bitcoin.cpp

@@ -27,7 +27,7 @@
 #include <qml/models/peerlistsortproxy.h>
 #include <qml/imageprovider.h>
 #include <qml/util.h>
-#include <qt/guiconstants.h>
+#include <qml/guiconstants.h>
 #include <qt/guiutil.h>
 #include <qt/initexecutor.h>
 #include <qt/networkstyle.h>

src/qml/guiconstants.h

@@ -0,0 +1,62 @@
+// Copyright (c) 2011-2024 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#ifndef BITCOIN_QML_GUICONSTANTS_H
+#define BITCOIN_QML_GUICONSTANTS_H
+
+#include <chrono>
+#include <cstdint>
+
+using namespace std::chrono_literals;
+
+/* A delay between model updates */
+static constexpr auto MODEL_UPDATE_DELAY{250ms};
+
+/* A delay between shutdown pollings */
+static constexpr auto SHUTDOWN_POLLING_DELAY{200ms};
+
+/* AskPassphraseDialog -- Maximum passphrase length */
+static const int MAX_PASSPHRASE_SIZE = 1024;
+
+/* BitcoinGUI -- Size of icons in status bar */
+static const int STATUSBAR_ICONSIZE = 16;
+
+static const bool DEFAULT_SPLASHSCREEN = true;
+
+/* Invalid field background style */
+#define STYLE_INVALID "background:#FF8080"
+
+/* Transaction list -- unconfirmed transaction */
+#define COLOR_UNCONFIRMED QColor(128, 128, 128)
+/* Transaction list -- negative amount */
+#define COLOR_NEGATIVE QColor(255, 0, 0)
+/* Transaction list -- bare address (without label) */
+#define COLOR_BAREADDRESS QColor(140, 140, 140)
+/* Transaction list -- TX status decoration - danger, tx needs attention */
+#define COLOR_TX_STATUS_DANGER QColor(200, 100, 100)
+/* Transaction list -- TX status decoration - default color */
+#define COLOR_BLACK QColor(0, 0, 0)
+
+/* Tooltips longer than this (in characters) are converted into rich text,
+   so that they can be word-wrapped.
+ */
+static const int TOOLTIP_WRAP_THRESHOLD = 80;
+
+/* Number of frames in spinner animation */
+#define SPINNER_FRAMES 36
+
+#define QAPP_ORG_NAME "Bitcoin"
+#define QAPP_ORG_DOMAIN "bitcoin.org"
+#define QAPP_APP_NAME_DEFAULT "Bitcoin-Qml"
+#define QAPP_APP_NAME_TESTNET "Bitcoin-Qml-testnet"
+#define QAPP_APP_NAME_SIGNET "Bitcoin-Qml-signet"
+#define QAPP_APP_NAME_REGTEST "Bitcoin-Qml-regtest"
+
+/* One gigabyte (GB) in bytes */
+static constexpr uint64_t GB_BYTES{1000000000};
+
+// Default prune target displayed in GUI.
+static constexpr int DEFAULT_PRUNE_TARGET_GB{2};
+
+#endif // BITCOIN_QML_GUICONSTANTS_H