Skip to content

Commit 48bc2c8

Browse files
committed
Merge #420: Wallet creation flow font weight and color tweaks
c753d16 Wallet creation flow font weight and color tweaks (GBKS) Pull request description: There are some very minor implementation discrepancies from the design in the wallet creation flow. The font weights for several titles are regular, but should be semi-bold (see all the other screens in the onboarding flow for examples). Two divider lines are neutral 7, but should be the neutral 4 color. See the following image with screenshots for the comparison. Top row shows the before, the bottom row shows the after. The second column is where the two divider line colors were adjusted. The other columns is where the font weight of the header was adjusted. ![image](https://github.com/user-attachments/assets/173955a9-438a-43b0-b5f7-9b23955b7286) This is my first PR for this project, let me know what I am doing wrong. ACKs for top commit: MarnixCroes: lgtm ACK c753d16 pablomartin4btc: utACK c753d16 Tree-SHA512: a26163620eb37712fb72811d2ce363bad025a2884d30abf03fc96e32b7fed04486f75be01f52120d42d8f0bf89aeb8551783b17bef75004af692fe742275a885
2 parents e7bea2d + c753d16 commit 48bc2c8

File tree

6 files changed

+7
-2
lines changed

6 files changed

+7
-2
lines changed

src/qml/pages/wallet/AddWallet.qml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ StackView {
4646
Layout.leftMargin: 20
4747
Layout.rightMargin: 20
4848
header: qsTr("Add a wallet")
49+
headerBold: true
4950
description: qsTr("In this early stage of development, only wallet.dat files are supported.")
5051
}
5152

src/qml/pages/wallet/CreateBackup.qml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ Page {
5555
Layout.leftMargin: 20
5656
Layout.rightMargin: 20
5757
header: qsTr("Back up your wallet")
58+
headerBold: true
5859
description: qsTr("Your wallet is a file stored on your hard disk.\nTo prevent accidental loss, it is recommended you keep a copy of your wallet file in a secure place, like a dedicated USB Drive.")
5960
}
6061

src/qml/pages/wallet/CreateConfirm.qml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ Page {
5555
Layout.leftMargin: 20
5656
Layout.rightMargin: 20
5757
header: qsTr("Your wallet has been created")
58+
headerBold: true
5859
description: qsTr("It is good practice to make a small test transaction before you actively use this wallet for larger amounts.")
5960
}
6061

src/qml/pages/wallet/CreateIntro.qml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ Page {
7272
Layout.leftMargin: 20
7373
Layout.rightMargin: 20
7474
Layout.fillWidth: true
75-
color: Theme.color.neutral7
75+
color: Theme.color.neutral4
7676
}
7777

7878
CoreText {
@@ -88,7 +88,7 @@ Page {
8888
Layout.leftMargin: 20
8989
Layout.rightMargin: 20
9090
Layout.fillWidth: true
91-
color: Theme.color.neutral7
91+
color: Theme.color.neutral4
9292
}
9393

9494
CoreText {

src/qml/pages/wallet/CreateName.qml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ Page {
3636
Layout.leftMargin: 20
3737
Layout.rightMargin: 20
3838
header: qsTr("Choose a wallet name")
39+
headerBold: true
3940
}
4041

4142
CoreTextField {

src/qml/pages/wallet/CreatePassword.qml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ Page {
4444
Layout.leftMargin: 20
4545
Layout.rightMargin: 20
4646
header: qsTr("Choose a password")
47+
headerBold: true
4748
description: qsTr("It is recommended to set a password to protect your wallet file from unwanted access from others.")
4849
}
4950

0 commit comments

Comments
 (0)