Closed
Conversation
Allowed to configure the proxy with an IPv6 address and moved the validation out from the UI/ control to the node interface.
6c0cb81 to
d9f99a9
Compare
d9f99a9 to
0c9722a
Compare
Addding the logic to persist the ip address and port values of both the default proxy and the tor proxy configuration into settings.js.
0c9722a to
8ef413b
Compare
Contributor
|
does it need rebase? |
Member
|
Is this specific to the QML GUI, or is it related to the Qt Widget-based GUI as well? |
Contributor
Author
This is purely QML GUI, Qt could benefit from it by reusing the proxy validation from the node interface instead of having it currently within the widget ( |
Member
|
Closing for now. Feel free to reopen this based on the new default branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


(This is based on top of #430).
Adding the required logic to persist the configuration of both default Proxy and Tor proxy values to
settings.json(location).Disabling a proxy thru its switch will remove the setting from the config file.
What to test on this PR:
Simply verify that the proxy value entered in the UI gets persisted into the file mentioned above, and if you manually touch the file or restart the application, the UI reflects the values read from the file.
How to test that the Proxy feature it's actually working:
1. Start
bitcoin-qtwith rpc enabled (with `-proxy` option OR leave it without it to verify that the value is getting read from the `settings.json` file)../src/qt/bitcoin-qt -regtest -proxy=127.0.0.1 -server=12. Run rpc
getnetworkinfofrombitcoin-clito verify the proxy has been set (you might need to update the-rpcportaccording to the chainnet selected option).guiPR #836.