-
Notifications
You must be signed in to change notification settings - Fork 49
Persist Proxy settings #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Persist Proxy settings #433
Conversation
Allowed to configure the proxy with an IPv6 address and moved the validation out from the UI/ control to the node interface.
6c0cb81
to
d9f99a9
Compare
d9f99a9
to
0c9722a
Compare
Addding the logic to persist the ip address and port values of both the default proxy and the tor proxy configuration into settings.js.
0c9722a
to
8ef413b
Compare
does it need rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 8ef413b works as expected on Ubuntu 20.04
Is this specific to the QML GUI, or is it related to the Qt Widget-based GUI as well? |
This is purely QML GUI, Qt could benefit from it by reusing the proxy validation from the node interface instead of having it currently within the widget ( |
(This is based on top of #430).
Adding the required logic to persist the configuration of both default Proxy and Tor proxy values to
settings.json
(location).Disabling a proxy thru its switch will remove the setting from the config file.
What to test on this PR:
Simply verify that the proxy value entered in the UI gets persisted into the file mentioned above, and if you manually touch the file or restart the application, the UI reflects the values read from the file.
How to test that the Proxy feature it's actually working:
1. Start
bitcoin-qt
with rpc enabled (with `-proxy` option OR leave it without it to verify that the value is getting read from the `settings.json` file)../src/qt/bitcoin-qt -regtest -proxy=127.0.0.1 -server=1
2. Run rpc
getnetworkinfo
frombitcoin-cli
to verify the proxy has been set (you might need to update the-rpcport
according to the chainnet selected option).gui
PR #836.