-
Notifications
You must be signed in to change notification settings - Fork 49
Introduce Send pages for singlesig, single input/output send #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current: Screencast.from.2025-02-20.10-18-37.mp4Goal: basic_send_flow_prototype.mp4There are a few immediate things I will be working on adjusting within the context of this PR to match the proposed designs. Primarily I will focus on the layout of the pages to match as well as the transition animations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It happens many times that clicking the
Review
button doesn't work.
Nothing happens, it doesn't go to SendReview page.
And then after adding or removing a zero it works. (always below balance)
- The address is cleared after send is confirmed and navigated back to Send page, the
Amount
andNote
should be cleared too?
} | ||
} | ||
|
||
ContinueButton { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe
make the button only click-able / highlighted on hover when there is a valid input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. I will be coming back to this as a Validation PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the build error:
RCC: Error in 'qml/bitcoin_qml.qrc': Cannot find file 'controls/LabeledTextInput.qml'
I suggest (UPDATED):
--- a/src/Makefile.qt.include
+++ b/src/Makefile.qt.include
@@ -353,6 +353,7 @@ QML_RES_ICONS = \
qml/res/icons/cross.png \
qml/res/icons/error.png \
qml/res/icons/export.png \
+ qml/res/icons/flip-vertical.png \
qml/res/icons/gear.png \
qml/res/icons/gear-outline.png \
qml/res/icons/hidden.png \
@@ -396,6 +397,7 @@ QML_RES_QML = \
qml/controls/ContinueButton.qml \
qml/controls/CoreText.qml \
qml/controls/CoreTextField.qml \
+ qml/controls/LabeledTextInput.qml \
qml/controls/ExternalLink.qml \
qml/controls/FocusBorder.qml \
qml/controls/Header.qml \
Why not keep files in buildsystem scripts sorted?
Want to update the PR and fix the CI? |
0490d58
to
9a863b0
Compare
Update:
|
Needs rebase. |
Both of these are good to notice and will be addressed The review button not working is due mainly to invalid inputs and are out of scope of the current basic implementation. This will be addressed as a validation PR. This will include error messaging. The form not clearing is good to note and I make an issue to address this when I come back around to validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 727aa52, I have skimmed through the code and it looks OK.
These changes implement the first iteration of the Send coins flow for our Desktop Wallet. A QML model, SendRecipient, is defined to hold the values entered into the Send form which will then be used to construct the actual transaction. The resulting transaction will be held in another new QML model, WalletQmlModelTransaction, and that will be held by the WalletModel and used to render the confirmation page, SendReview.qml. This is designed to closely mirror the objects used in the current Qt SendCoinsDialog modules.