Skip to content

Add Skeleton loading animation to the Wallet selector #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

johnny9
Copy link
Contributor

@johnny9 johnny9 commented May 21, 2025

This adds the first skeleton loading section to the desktop wallet. Specifically the WalletBadge at the top left corner that is used for selecting a wallet.

untitled.mp4

@johnny9 johnny9 changed the title Skeleton loading Add Skeleton loading animation to the Wallet selector May 21, 2025
@johnny9
Copy link
Contributor Author

johnny9 commented May 21, 2025

gradientshimmer.mp4

Here is an attempt at the gradient shimmer

@johnny9 johnny9 force-pushed the skeleton-loading branch from 1f65d17 to 9a53889 Compare May 21, 2025 05:11
@johnny9
Copy link
Contributor Author

johnny9 commented May 21, 2025

Update from 1f65d17 to 9a53889

  • Replaced the Animation in Skeleton with the gradient "shimmer" animation.

@GBKS
Copy link
Contributor

GBKS commented May 21, 2025

Looks great (from the video). Just built the code and tried to check it out in the app, but things load so quickly for me that I don't see it. Do I need to load it up with lots of transactions, or does it only show during IBD or so?

Small thing I noticed is that the content of the wallet display wiggles a bit horizontally when the name is shorter/longer than the balance. Could we please align things to the left?

40185

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested LGTM 9a53889

@johnny9 johnny9 force-pushed the skeleton-loading branch from 9a53889 to 99ca9fd Compare May 22, 2025 04:30
@johnny9
Copy link
Contributor Author

johnny9 commented May 22, 2025

Update from 9a53889 to 99ca9fd

  • Removed semicolons in the qml
  • Removed useless anchor in Item

@johnny9
Copy link
Contributor Author

johnny9 commented May 22, 2025

Looks great (from the video). Just built the code and tried to check it out in the app, but things load so quickly for me that I don't see it. Do I need to load it up with lots of transactions, or does it only show during IBD or so?

Small thing I noticed is that the content of the wallet display wiggles a bit horizontally when the name is shorter/longer than the balance. Could we please align things to the left?

Created an issue to track this. It should be possible to fix the alignment. #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants