-
Notifications
You must be signed in to change notification settings - Fork 49
Add Skeleton loading animation to the Wallet selector #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gradientshimmer.mp4Here is an attempt at the gradient shimmer |
Looks great (from the video). Just built the code and tried to check it out in the app, but things load so quickly for me that I don't see it. Do I need to load it up with lots of transactions, or does it only show during IBD or so? Small thing I noticed is that the content of the wallet display wiggles a bit horizontally when the name is shorter/longer than the balance. Could we please align things to the left? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested LGTM 9a53889
Created an issue to track this. It should be possible to fix the alignment. #456 |
This adds the first skeleton loading section to the desktop wallet. Specifically the WalletBadge at the top left corner that is used for selecting a wallet.
untitled.mp4