Disable forms when loading #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looking good. Small tweak would be to use Neutral 4 for the disabled text and lines. This PR seems to use Neutral 2, which is barely visible. |
Collaborator
Author
I'll change it to Neutral 4 |
Collaborator
Author
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
2d0a81f qml: Disable Send/Receive forms when loading (johnny9) 5b56c2c qml: Add initialized property to WalletQmlController (johnny9) Pull request description: During loading, the Send and Receive forms are disabled and greyed out. This includes the initialized property added to WalletQmlController just as in #455   ACKs for top commit: MarnixCroes: tACK 2d0a81f Tree-SHA512: 45b7324e77a529a1b7af7c663b701a346a292f2a8427088e3d0d51a5df856fadbf8b7b2c164eb0bbb7d0bf55dd48cc237d28d58fa58569b9fe8a5b507910b2dc
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
2d0a81fde68a6da08dd0b31b28684f4878f5ae5c qml: Disable Send/Receive forms when loading (johnny9) 5b56c2cdf8ad8ace263b39c796a5bea7a86337f2 qml: Add initialized property to WalletQmlController (johnny9) Pull request description: During loading, the Send and Receive forms are disabled and greyed out. This includes the initialized property added to WalletQmlController just as in #455   ACKs for top commit: MarnixCroes: tACK 2d0a81fde68a6da08dd0b31b28684f4878f5ae5c Tree-SHA512: 45b7324e77a529a1b7af7c663b701a346a292f2a8427088e3d0d51a5df856fadbf8b7b2c164eb0bbb7d0bf55dd48cc237d28d58fa58569b9fe8a5b507910b2dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During loading, the Send and Receive forms are disabled and greyed out.
This includes the initialized property added to WalletQmlController just as in #455