Activity page fixes #476
Merged
Activity page fixes #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listView needs an explict anchor.fill: parent because its parent is an Item.
pinheadmz
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
ACK ffd0c09
built and tested macos/arm64, reviewed the minimal diff, works as expected. Thanks!
Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
ACK ffd0c09e77c3fec14f5105f125281d2f3442adcb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmh/aasACgkQ5+KYS2KJ
yTpdKA/+O9Ed/nGLJoECNja0AB/DOnRh3XYLt2CfMJ+PyNy7OMAPIp9YAOBGB+nb
mQz4vNCLbUp8LEr4BuDG4YAcuJfwcPyAsE7m16lSUlpIGpQVZGNbBx3MCrJPgy0f
YTCWT/NGA+bylqvQkGAemJGuApVwk3iN1bhGDODCg8LViZOne8GIaRxDNQi30UtT
y5fkxI1hsrw6EC1n2jREXer023N4QyA0uqBZpjkIkJOVRDpRMq6QGgyI9cEJT1D1
qiejEqd6OFYV2qrvPlN9mAv8YkAskBL/PMgGks91K6EaxFZ7/WwlVJOUa1zlfGI8
KQuHciE72v/4HqF7kzUGIo3LGdvS5mxUCgPMiCzU0IqocKQj3vb7tY3VYimGsQ09
HzUcVMhVH97dRhYx6F0pN4pJi7B0x0TKc37ua1i+Re4znjrPmQe0JPYG0CnOPhmZ
No9BWJ4y8kRlq6Xbk3cr6bKvQ+iVEat1qn0ynO2M6yE0TBpUGBOHDWj4WFjsAwac
0j3UIADEP1C8krH2cZTn6aA1IPXaRT5PB5bYfkNOL3ejgkEf0CIAMvLdM7stcW17
Fjhx3xUKfB6EZFoVaNCb/e9dcId8IfZXUO5m52bxsrDINSu8tv2fEa3NflSPbB0D
rmxhLMkuzOMlti2ZGS1oeiRwUy87ZfhgG2eUcLi2min56CeSBKk=
=9Okt
-----END PGP SIGNATURE-----
pinheadmz's public key is on openpgp.org
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
ffd0c09e77c3fec14f5105f125281d2f3442adcb Fix stackView reference in Activity (johnny9) d92a6265cb8421e05ae827bdf6d21b1e85db216b Fix Activity listView's anchors (johnny9) Pull request description: There were two errors that prevented the Activity page from working correctly The first was a missing anchor for the listView, The patch correctly has the listView fill its parent so it appears now. Before: <img width="869" height="716" alt="Screenshot from 2025-07-21 22-57-11" src="https://github.com/user-attachments/assets/21c4801f-831d-4efa-b5d8-28cf49f6eca5" /> After: <img width="869" height="716" alt="Screenshot from 2025-07-21 22-57-18" src="https://github.com/user-attachments/assets/d32b827c-6093-4dae-a0cf-6107c5cff77b" /> The second fix fixes a bad reference to the stackView and gets rid of the following error in debug.log `2025-07-22T02:47:12Z GUI: qrc:/qml/pages/wallet/Activity.qml:19: TypeError: Cannot call method 'pop' of null` ACKs for top commit: pinheadmz: ACK ffd0c09e77c3fec14f5105f125281d2f3442adcb Tree-SHA512: ffb055f74012795a4ffc68b96396e7529fdb6e866e69b81f4907534aef8cbd919126f6967d5b6c5cd0f7495c2a6e65f07a94596ae21cf92d19a76e53fce9d4ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two errors that prevented the Activity page from working correctly
The first was a missing anchor for the listView, The patch correctly has the listView fill its parent so it appears now.
Before:
After:
The second fix fixes a bad reference to the stackView and gets rid of the following error in debug.log
2025-07-22T02:47:12Z GUI: qrc:/qml/pages/wallet/Activity.qml:19: TypeError: Cannot call method 'pop' of null