Various fixes to Send, WalletController, and general QML #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
reviewed
Jul 27, 2025
qml/components/BlockClock.qml
Outdated
| import QtQuick.Controls 2.15 | ||
| import QtQuick.Layouts 1.15 | ||
| import Qt.labs.settings 1.0 | ||
| import QtCore |
There was a problem hiding this comment.
The Settings QML Type was introduced in QtCore in Qt 6.5.
Our minimum supported Qt version is currently 6.2.
There was a problem hiding this comment.
Ok good to know. I'll drop that commit then.
What is the workflow in the UI for that? |
|
The last 2 commits don't look as a complete solution. Consider mouse clicking on the "minus" button in the "Send" view: |
I think i resolved those problems now as well. |
hebasto
reviewed
Jul 28, 2025
There was a problem hiding this comment.
Tested c20390d.
When closing the app:
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:258: TypeError: Cannot read property 'label' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:234: TypeError: Cannot read property 'amount' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:212: TypeError: Cannot read property 'amount' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:178: TypeError: Cannot read property 'address' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:31: TypeError: Cannot read property 'recipients' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:19: TypeError: Cannot read property 'recipients' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:269: TypeError: Cannot read property 'coinsListModel' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:270: TypeError: Cannot read property 'coinsListModel' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:161: TypeError: Cannot read property 'recipients' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:150: TypeError: Cannot read property 'recipients' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:139: TypeError: Cannot read property 'recipients' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:127: TypeError: Cannot read property 'recipients' of null
2025-07-28T07:56:04Z GUI: qrc:/qml/pages/wallet/Send.qml:116: TypeError: Cannot read property 'recipients' of null
Updated the commits and I believe this is resolved fully now. |
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
…er, and general QML
18e008cfc8532c6bb9af6e218bd920046d57cc57 Signal currentRecipientChanged before deleting in SendRecipientsListModel::remove (johnny9)
cc500785545bc6fda5540fd26486565829c17abd Set m_selected_wallet to empty before unloading (johnny9)
f8eb08f30ac127173872827f729ff430025c0899 Reset current index before clearing in SendRecipientsListModel (johnny9)
c8c54a1252ba2d5ecd7fb1a6097ef5492185377a Add missing buttonText id to EllipsisMenuToggleItem (johnny9)
Pull request description:
The following errors are resolved with these commits.
Missing id for buttonText in EllipsesMenuToggleItem
```
2025-07-27T01:40:01Z GUI: qrc:/qml/controls/EllipsisMenuToggleItem.qml:71: ReferenceError: buttonText is not defined
2025-07-27T01:40:01Z GUI: qrc:/qml/controls/EllipsisMenuToggleItem.qml:71:13: QML PropertyChanges: Cannot assign to non-existent property "color"
```
Null Property after toggling off Multiple Recipients toggle and removing Recipients with the "-" icon
```
2025-07-27T01:40:03Z GUI: qrc:/qml/pages/wallet/Send.qml:258: TypeError: Cannot read property 'label' of null
2025-07-27T01:40:03Z GUI: qrc:/qml/pages/wallet/Send.qml:234: TypeError: Cannot read property 'amount' of null
2025-07-27T01:40:03Z GUI: qrc:/qml/pages/wallet/Send.qml:212: TypeError: Cannot read property 'amount' of null
2025-07-27T01:40:03Z GUI: qrc:/qml/pages/wallet/Send.qml:178: TypeError: Cannot read property 'address' of null
```
Null properties after all wallets are unloaded
```
2025-07-27T01:40:44Z GUI: qrc:/qml/pages/wallet/Send.qml:258: TypeError: Cannot read property 'label' of null
2025-07-27T01:40:44Z GUI: qrc:/qml/pages/wallet/Send.qml:234: TypeError: Cannot read property 'amount' of null
2025-07-27T01:40:44Z GUI: qrc:/qml/pages/wallet/Send.qml:212: TypeError: Cannot read property 'amount' of null
2025-07-27T01:40:44Z GUI: qrc:/qml/pages/wallet/Send.qml:178: TypeError: Cannot read property 'address' of null
2025-07-27T01:40:44Z GUI: qrc:/qml/pages/wallet/Send.qml:31: TypeError: Cannot read property 'recipients' of null
```
ACKs for top commit:
hebasto:
ACK 18e008cfc8532c6bb9af6e218bd920046d57cc57, tested on Ubuntu 24.04.
Tree-SHA512: 3c58676bb19cf524b3661e5f51260ace5cc70bc43ff94fbf14ae48ea7d2a69c76cdbe2988f02435ac53ea9dce0c68d1b8d8fc0163ceab376e3c5fa6fee82c001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following errors are resolved with these commits.
Missing id for buttonText in EllipsesMenuToggleItem
Null Property after toggling off Multiple Recipients toggle and removing Recipients with the "-" icon
Null properties after all wallets are unloaded