Add PeerTableQmlModel #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream PeerTableModel does not expose its startAutoRefresh and stopAutoRefresh methods as invokable so the PeerTableQmlModel is introduced to make these methods invokable in qml.
hebasto
reviewed
Aug 1, 2025
qml/models/peertableqmlmodel.h
Outdated
| Q_INVOKABLE void stopAutoRefresh(); | ||
| }; | ||
|
|
||
| #endif // PEERTABLEQMLMODEL_H |
There was a problem hiding this comment.
Suggested change
| #endif // PEERTABLEQMLMODEL_H | |
| #endif // BITCOIN_QML_MODELS_PEERTABLEQMLMODEL_H |
johnny9
force-pushed
the
peers-qml
branch
2 times, most recently
from
14c2540 to
a0d6179
Compare
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
a0d617925d17e4af15e1b424e72c9c6fbbd71671 Add PeerTableQmlModel (johnny9)
Pull request description:
The upstream PeerTableModel does not expose its startAutoRefresh and stopAutoRefresh methods as invokable so the PeerTableQmlModel is introduced to make these methods invokable in qml.
fixes #482
ACKs for top commit:
hebasto:
ACK a0d617925d17e4af15e1b424e72c9c6fbbd71671, tested on Ubuntu 24.04.
Tree-SHA512: dbc1002325be16e7c93b5c14d31dac541617833ebbaddf1a461b042a74f37b5d8bf450c1903d37d53c516be89c7883aa04a61ddf71e6d830a7d306053fd00729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream PeerTableModel does not expose its startAutoRefresh and stopAutoRefresh methods as invokable so the PeerTableQmlModel is introduced to make these methods invokable in qml.
fixes #482