Use handlers with explicit parameters in main.qml and DesktopWallets.qml #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
… in main.qml and DesktopWallets.qml
99d5da865466924257daf4d8b59db468992c69e6 Update signal handlers in DesktopWallets.qml to have explicit parameters (johnny9)
da6bc7cd97f4c5be66ab77411509fac5a145cde8 Update signal handlers in main.qml to have explicit parameters (johnny9)
Pull request description:
Signals with parameters should have handlers that explicitly define the arguments. Without this, Qt will throw a warning in the log stating that injection or parameters is deprecated.
fixes #481
ACKs for top commit:
hebasto:
ACK 99d5da865466924257daf4d8b59db468992c69e6, tested on Ubuntu 24.04.
Tree-SHA512: 510ab99aeaa8418cc28886452bed28d7cc8c6697286e89d19e4a5cc593dda5f3d07d1e7ca5856be60dc8c6efb50d8e1626ca1a111457dbede6267bf6d1bfe62c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signals with parameters should have handlers that explicitly define the arguments. Without this, Qt will throw a warning in the log stating that injection or parameters is deprecated.
fixes #481