fix: handle zero-input transaction parsing#2298
Open
0xsatoshi99 wants to merge 1 commit intobitcoinjs:masterfrom
Open
fix: handle zero-input transaction parsing#22980xsatoshi99 wants to merge 1 commit intobitcoinjs:masterfrom
0xsatoshi99 wants to merge 1 commit intobitcoinjs:masterfrom
Conversation
When parsing a transaction with 0 inputs, the byte sequence 00 01 (vinLen=0, voutLen=1) was incorrectly interpreted as segwit marker/flag. This fix validates the segwit interpretation by checking: 1. If vinLen would be 0 (segwit tx with 0 inputs is invalid) 2. If the buffer is too small to contain the claimed number of inputs If either check fails, fall back to non-segwit parsing. Fixes bitcoinjs#2293
Author
|
@junderw Can you plz check this PR and let me know your feedback? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes parsing of transactions and PSBTs with zero inputs.
Problem
When parsing a transaction with 0 inputs, the byte sequence
00 01(vinLen=0, voutLen=1) was incorrectly interpreted as the segwit marker/flag bytes. This caused:Transaction.fromBuffer()to fail on zero-input transactionsPsbt.fromBase64()to fail when deserializing PSBTs with no inputsSolution
After detecting potential segwit marker/flag (
00 01), validate the interpretation by checking:If either check fails, rewind and parse as a non-segwit transaction.
Testing
All 2660 existing tests pass.
Fixes #2293
Contribution by Gittensor, learn more at https://gittensor.io/