docs: update browser bundling instructions for v7#2314
Open
jasonandjay wants to merge 1 commit intobitcoinjs:masterfrom
Open
docs: update browser bundling instructions for v7#2314jasonandjay wants to merge 1 commit intobitcoinjs:masterfrom
jasonandjay wants to merge 1 commit intobitcoinjs:masterfrom
Conversation
Replace outdated browserify instructions with esbuild guidance. Since v7 ships as a dual CJS/ESM package with .cjs extensions, browserify can no longer properly resolve internal imports. Closes bitcoinjs#2210 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browserifyinstructions withesbuildguidance in the Browser section of README.cjsfile extensions, browserify can no longer properly resolve internal imports, producing broken bundlesbufferwarning and thebabelifynote, replacing them with a simpler Babel referenceChanges
esbuildas the primary browser bundler with a working examplewebpackandrollupas alternatives<script>) and ESM (<script type="module">) usage examplesCloses #2210
Test plan