[BREAKING CHANGE] Remove TypeSystem completely, and add AsDynamic(..), AsTyped<T..>(..) extension methods

- Version of Using(..) and UsingEncoder(...) that took an IKeyEncoding are renamed to AsDynamic() or AsTyped<T...>()
- The encoding is optional, and will use TuPack.Encoding by default
- Changed the KeySubspace.Copy(...) into extension methods

Author: KrzysFR

FdbShell/Commands/BasicCommands.cs

@@ -70,16 +70,16 @@ public static async Task Dir(string[] path, ITuple extras, DirectoryBrowseOption
 							if (!(subfolder is FdbDirectoryPartition))
 							{
 								long count = await Fdb.System.EstimateCountAsync(db, subfolder.Keys.ToRange(), ct);
-								log.WriteLine("  {0,-12} {1,-12} {3,9:N0} {2}", FdbKey.Dump(KeySubspace.Copy(subfolder).GetPrefix()), subfolder.Layer.IsNullOrEmpty ? "-" : ("<" + subfolder.Layer.ToUnicode() + ">"), name, count);
+								log.WriteLine("  {0,-12} {1,-12} {3,9:N0} {2}", FdbKey.Dump(subfolder.Copy().GetPrefix()), subfolder.Layer.IsNullOrEmpty ? "-" : ("<" + subfolder.Layer.ToUnicode() + ">"), name, count);
 							}
 							else
 							{
-								log.WriteLine("  {0,-12} {1,-12} {3,9} {2}", FdbKey.Dump(KeySubspace.Copy(subfolder).GetPrefix()), subfolder.Layer.IsNullOrEmpty ? "-" : ("<" + subfolder.Layer.ToUnicode() + ">"), name, "-");
+								log.WriteLine("  {0,-12} {1,-12} {3,9} {2}", FdbKey.Dump(subfolder.Copy().GetPrefix()), subfolder.Layer.IsNullOrEmpty ? "-" : ("<" + subfolder.Layer.ToUnicode() + ">"), name, "-");
 							}
 						}
 						else
 						{
-							log.WriteLine("  {0,-12} {1,-12} {2}", FdbKey.Dump(KeySubspace.Copy(subfolder).GetPrefix()), subfolder.Layer.IsNullOrEmpty ? "-" : ("<" + subfolder.Layer.ToUnicode() + ">"), name);
+							log.WriteLine("  {0,-12} {1,-12} {2}", FdbKey.Dump(subfolder.Copy().GetPrefix()), subfolder.Layer.IsNullOrEmpty ? "-" : ("<" + subfolder.Layer.ToUnicode() + ">"), name);
 						}
 					}
 					else
@@ -217,7 +217,7 @@ public static async Task Count(string[] path, ITuple extras, IFdbDatabase db, Te
 				return;
 			}
 
-			var copy = KeySubspace.Copy(folder);
+			var copy = folder.Copy();
 			log.WriteLine("# Counting keys under {0} ...", FdbKey.Dump(copy.GetPrefix()));
 
 			var progress = new Progress<(long Count, Slice Current)>((state) =>
@@ -555,7 +555,7 @@ public static async Task Shards(string[] path, ITuple extras, IFdbDatabase db, T
 			var folder = (await TryOpenCurrentDirectoryAsync(path, db, ct)) as FdbDirectorySubspace;
 			if (folder != null)
 			{
-				var r = KeyRange.StartsWith(KeySubspace.Copy(folder).GetPrefix());
+				var r = KeyRange.StartsWith(folder.Copy().GetPrefix());
 				Console.WriteLine("Searching for shards that intersect with /{0} ...", String.Join("/", path));
 				ranges = await Fdb.System.GetChunksAsync(db, r, ct);
 				Console.WriteLine("Found {0} ranges intersecting {1}:", ranges.Count, r);
@@ -590,7 +590,7 @@ public static async Task Sampling(string[] path, ITuple extras, IFdbDatabase db,
 			KeyRange span;
 			if (folder is FdbDirectorySubspace)
 			{
-				span = KeyRange.StartsWith(KeySubspace.Copy(folder as FdbDirectorySubspace).GetPrefix());
+				span = KeyRange.StartsWith((folder as FdbDirectorySubspace).Copy().GetPrefix());
 				log.WriteLine("Reading list of shards for /{0} under {1} ...", String.Join("/", path), FdbKey.Dump(span.Begin));
 			}
 			else

FoundationDB.Client/Subspaces/Fdb.Directory.cs

@@ -85,7 +85,7 @@ public static async Task<IFdbDatabase> OpenNamedPartitionAsync(string clusterFil
 					if (Logging.On) Logging.Verbose(typeof(Fdb.Directory), "OpenNamedPartitionAsync", $"Found named partition '{descriptor.FullName}' at prefix {descriptor}");
 
 					// we have to chroot the database to the new prefix, and create a new DirectoryLayer with a new '/'
-					rootSpace = KeySubspace.Copy(descriptor); //note: create a copy of the key
+					rootSpace = descriptor.Copy(); //note: create a copy of the key
 					//TODO: find a nicer way to do that!
 					db.ChangeRoot(rootSpace, FdbDirectoryLayer.Create(rootSpace, partitionPath), readOnly);
 

FoundationDB.Client/Subspaces/KeySubspace.cs

@@ -141,95 +141,6 @@ public static TypedKeySubspace<T1, T2, T3, T4> CreateTyped<T1, T2, T3, T4>(Slice
 
 		#endregion
 
-		#region Copy...
-
-		/// <summary>Create a new copy of a subspace's prefix</summary>
-		[Pure]
-		internal static Slice StealPrefix([NotNull] IKeySubspace subspace)
-		{
-			//note: we can workaround the 'security' in top directory partition by accessing their key prefix without triggering an exception!
-			return subspace is KeySubspace ks
-				? ks.Key.Memoize()
-				: subspace.GetPrefix().Memoize();
-		}
-
-		/// <summary>Create a copy of a generic subspace, sharing the same binary prefix</summary>
-		[Pure, NotNull]
-		public static KeySubspace Copy([NotNull] IKeySubspace subspace)
-		{
-			Contract.NotNull(subspace, nameof(subspace));
-
-			var prefix = StealPrefix(subspace);
-
-			if (subspace is IDynamicKeySubspace dyn)
-			{ // reuse the encoding of the original
-				return new DynamicKeySubspace(prefix, dyn.Encoding);
-			}
-
-			// no encoding
-			return new KeySubspace(prefix);
-		}
-
-		/// <summary>Create a copy of a generic subspace, sharing the same binary prefix</summary>
-		[Pure, NotNull]
-		public static DynamicKeySubspace Copy([NotNull] IKeySubspace subspace, IKeyEncoding encoding)
-		{
-			Contract.NotNull(subspace, nameof(subspace));
-			Contract.NotNull(encoding, nameof(encoding));
-			return new DynamicKeySubspace(StealPrefix(subspace), encoding);
-		}
-
-		/// <summary>Create a copy of a generic subspace, sharing the same binary prefix</summary>
-		[Pure, NotNull]
-		public static DynamicKeySubspace Copy([NotNull] IKeySubspace subspace, IDynamicKeyEncoder encoder)
-		{
-			Contract.NotNull(subspace, nameof(subspace));
-			Contract.NotNull(encoder, nameof(encoder));
-			return new DynamicKeySubspace(StealPrefix(subspace), encoder);
-		}
-
-		/// <summary>Create a copy of a dynamic subspace, sharing the same binary prefix and encoder</summary>
-		[Pure, NotNull]
-		public static DynamicKeySubspace Copy([NotNull] IDynamicKeySubspace subspace)
-		{
-			Contract.NotNull(subspace, nameof(subspace));
-			return new DynamicKeySubspace(StealPrefix(subspace), subspace.Encoding);
-		}
-
-		/// <summary>Create a copy of a typed subspace, sharing the same binary prefix and encoder</summary>
-		[Pure, NotNull]
-		public static TypedKeySubspace<T1> Copy<T1>([NotNull] ITypedKeySubspace<T1> subspace)
-		{
-			Contract.NotNull(subspace, nameof(subspace));
-			return new TypedKeySubspace<T1>(StealPrefix(subspace), subspace.KeyEncoder);
-		}
-
-		/// <summary>Create a copy of a typed subspace, sharing the same binary prefix and encoder</summary>
-		[Pure, NotNull]
-		public static TypedKeySubspace<T1, T2> Copy<T1, T2>([NotNull] ITypedKeySubspace<T1, T2> subspace)
-		{
-			Contract.NotNull(subspace, nameof(subspace));
-			return new TypedKeySubspace<T1, T2>(StealPrefix(subspace), subspace.KeyEncoder);
-		}
-
-		/// <summary>Create a copy of a typed subspace, sharing the same binary prefix and encoder</summary>
-		[Pure, NotNull]
-		public static TypedKeySubspace<T1, T2, T3> Copy<T1, T2, T3>([NotNull] ITypedKeySubspace<T1, T2, T3> subspace)
-		{
-			Contract.NotNull(subspace, nameof(subspace));
-			return new TypedKeySubspace<T1, T2, T3>(StealPrefix(subspace), subspace.KeyEncoder);
-		}
-
-		/// <summary>Create a copy of a typed subspace, sharing the same binary prefix and encoder</summary>
-		[Pure, NotNull]
-		public static TypedKeySubspace<T1, T2, T3, T4> Copy<T1, T2, T3, T4>([NotNull] ITypedKeySubspace<T1, T2, T3, T4> subspace)
-		{
-			Contract.NotNull(subspace, nameof(subspace));
-			return new TypedKeySubspace<T1, T2, T3, T4>(StealPrefix(subspace), subspace.KeyEncoder);
-		}
-
-		#endregion
-
 		internal KeySubspace(Slice prefix)
 		{
 			this.Key = prefix;
@@ -260,7 +171,7 @@ protected virtual Slice GetKeyPrefix()
 
 		/// <summary>Returns the master instance of the prefix, without any safety checks</summary>
 		/// <remarks>This instance should NEVER be exposed to anyone else, and should ONLY be used for logging/troubleshooting</remarks>
-		protected Slice GetPrefixUnsafe()
+		internal Slice GetPrefixUnsafe()
 		{
 			return this.Key;
 		}