Limit backup job name to 63 chars, fix #836

Author: Vladimir Fidunin

pkg/internal/mysqlbackup/mysqlbackup.go

@@ -79,7 +79,11 @@ func (b *MysqlBackup) composeBackupURL(base string) string {
 
 // GetNameForJob returns the name of the job
 func (b *MysqlBackup) GetNameForJob() string {
-	return fmt.Sprintf("%s-backup", b.Name)
+	prefix := b.Name
+	if len(prefix) >= 56 {
+		prefix = fmt.Sprintf("%s-%d", prefix[:44], hash(prefix))
+	}
+	return fmt.Sprintf("%s-backup", prefix)
 }
 
 // GetNameForDeletionJob returns the name for the hard deletion job.

pkg/internal/mysqlbackup/mysqlbackup_test.go

@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://wwb.apache.org/licenses/LICENSE-2.0
+	http://wwb.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
@@ -55,4 +55,22 @@ var _ = Describe("MySQL backup unit tests", func() {
 		Expect(backup.GetNameForDeletionJob()).To(Equal("not-too-long-backup-name-for-testing-cleanup-job-test-cleanup"))
 		Expect(len(backup.GetNameForDeletionJob())).To(BeNumerically("<=", 63))
 	})
+
+	It("should generate the correct backup job name", func() {
+		backup := New(&api.MysqlBackup{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: "backup-name",
+			},
+		})
+
+		Expect(backup.GetNameForJob()).To(Equal("backup-name-backup"))
+
+		backup.Name = "super-long-backup-name-for-testing-backup-job-name-generator"
+		Expect(backup.GetNameForJob()).To(Equal("super-long-backup-name-for-testing-backup-jo-4133418200-backup"))
+		Expect(len(backup.GetNameForJob())).To(BeNumerically("<=", 63))
+
+		backup.Name = "not-too-long-backup-name-for-testing-backup-job-test"
+		Expect(backup.GetNameForJob()).To(Equal("not-too-long-backup-name-for-testing-backup-job-test-backup"))
+		Expect(len(backup.GetNameForJob())).To(BeNumerically("<=", 63))
+	})
 })