[ACI-3750] Add activate command #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Badlazzor wants to merge 26 commits into main from add-activate-command

Contributor

Badlazzor commented Jun 4, 2025

No description provided.

Badlazzor requested a review from zsolt-marta-bitrise

June 4, 2025 10:17

zsolt-marta-bitrise reviewed

View reviewed changes

cmd/activate.go Outdated Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

cmd/activateForGradle_test.go Outdated Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

cmd/enableForGradle.go Outdated Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

internal/config/gradle/gradleconfig.go Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

internal/config/gradle/gradleconfig_test.go Outdated Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

cmd/activateForGradle_test.go Outdated Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

internal/config/gradle/gradleconfig.go Outdated Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

internal/config/gradle/gradleconfig.go Outdated Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

internal/config/gradle/initd.gradle.kts.gotemplate Outdated Show resolved Hide resolved

Badlazzor changed the title ~~Add activate command~~ [ACI-3764] Add activate command

Badlazzor force-pushed the add-activate-command branch from 415cadc to 4dc41fb Compare

June 10, 2025 11:33

Badlazzor changed the title ~~[ACI-3764] Add activate command~~ [ACI-3750] Add activate command

Badlazzor force-pushed the add-activate-command branch 2 times, most recently from dbeebb1 to 9ee2f1f Compare

June 17, 2025 10:17

Badlazzor mentioned this pull request

[ACI-3782] Fetch bitrise plugins to local repository #134

Merged

Badlazzor added 14 commits

June 18, 2025 11:46


          Add activate command (activating plugins) + minor cleanup on paramete…

8b75a6d

…rs passed


          Cover activate with unit tests

2730ffe


          Use assignment instead of set for cache params

da3de13


          Create various helper structs and proxies for testing. Update tests.

118da8c


          Use envProvider instead of od.getenv directly

5b2d68f


          Update gradle verification

5450c21


          Fix cache level usage

aa0882d


          Reset verification metadata

77cfca5


          Add test-distribution to verification metadata

4d75880


          Update verification metadata

3f4ef40


          Update verification metadata

8fe4308


          Set enabled on analytics in init.gradle

434030e


          Add enabled=true to init gradle text generation when activating analy…

b8d8b74

…tics


          Update scripts accommodating new plugin

5c585cb

Badlazzor added 3 commits

June 18, 2025 11:46


          Remove test file reintroduced by rebase, add missing repos to tests

217c236


          Add test distribution to plugin caching, rename file to snake_case

8be8d7b


          Make test expectations on generated gradle.init file come from parts …

edc37aa

…so we can reuse them

Badlazzor force-pushed the add-activate-command branch from ec367f8 to edc37aa Compare

June 18, 2025 09:46

Badlazzor added 2 commits

June 18, 2025 11:50


          Update verification metadata to match the one expected by the CI

87a87ef


          Clarify already downloaded file ignorance, log PWD fallback

873a31e

Contributor Author

Badlazzor commented Jun 18, 2025

*.pb.go files were automatically formatted by goimports -w . . Seems good and I didn't want to ignore them in every future update.

Badlazzor requested a review from zsolt-marta-bitrise

June 18, 2025 11:27

zsolt-marta-bitrise reviewed

View reviewed changes

cmd/gradle_properties_from_params.go Outdated Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

cmd/gradle_properties_from_params_test.go Outdated Show resolved Hide resolved

Badlazzor added 2 commits

June 18, 2025 14:45


          Move ActivateForGradleParams to gradle package, move `ReadFileIfExi…

42aff0a

…sts` to `OsProxy`


          Update expected error in test for activate command

d32ce1d

zsolt-marta-bitrise reviewed

View reviewed changes

internal/config/gradle/gradle_properties_from_params_test.go Show resolved Hide resolved

zsolt-marta-bitrise reviewed

View reviewed changes

cmd/activate_for_gradle.go Outdated Show resolved Hide resolved

Badlazzor added 5 commits

June 18, 2025 15:36


          Move global activate for gradle param struct to cmd level

1e0aea6


          Remove globals from activate_for_gradle_params.go

f5f95cd


          Remove surplus dependencies in activateForGradleCmdFn function params

326f851


          Update e2e tests to use activate instead of enable for gradle

3e4ba84


          Fix cli calls in yaml (activate-for -> activate)

901b21d

zsolt-marta-bitrise approved these changes

View reviewed changes

Collaborator

zsolt-marta-bitrise left a comment

Nice work 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet