Add activate command #127
Add activate command #127
Conversation
| var activateCmd = &cobra.Command{ //nolint:gochecknoglobals | ||
| Use: "activate", | ||
| Short: "Activate various bitrise plugins", | ||
| Long: `Activate Gradle, Bazel, etc. Plugins |
There was a problem hiding this comment.
| Long: `Activate Gradle, Bazel, etc. Plugins | |
| Long: `Activate Gradle, Bazel, etc. plugins |
| initGradlecontent, err := ReadActivatedPluginsFromInitGradle(filepath.Join(tmpGradleHomeDir, "init.d", "bitrise-build-cache.init.gradle.kts")) | ||
| require.NoError(t, err) | ||
| expected := `import io.bitrise.gradle.cache.BitriseBuildCache | ||
| import io.bitrise.gradle.cache.BitriseBuildCacheServiceFactory |
There was a problem hiding this comment.
Do we need to test the output config file in a detailed way? We have tests for the config in gradleconfig_test.go
There was a problem hiding this comment.
The logic in the activate where we turn mostly boolean flags into 3 way states and that some configurations are not required for dep only additions wouldn't be tested by the gradleconfig tests.
There was a problem hiding this comment.
Ah I see the problem, it's that writeGradleInit is a function, not a struct that can be mocked. I'd extract it to a proper testable package/struct/interface and just assert the preferences it gets from the commands
| } | ||
|
|
||
| // Generate init.gradle content. | ||
| // Recommended to save the content into $HOME/.gradle/init.d/ instead of | ||
| // overwriting the $HOME/.gradle/init.gradle file. | ||
| func GenerateInitGradle(endpointURL, authToken string, preferences Preferences, cacheConfigMetadata common.CacheConfigMetadata) (string, error) { |
There was a problem hiding this comment.
Nice cleanup 👍🏻
| classpath("io.bitrise.gradle:gradle-analytics:2.1.28") | ||
| classpath("io.bitrise.gradle:remote-cache:1.2.19") |
There was a problem hiding this comment.
Don't forget to update the version bump automation
| maven(url="https://jitpack.io") | ||
| } | ||
| dependencies { | ||
| classpath("io.bitrise.gradle:gradle-analytics:2.1.28") |
There was a problem hiding this comment.
Yeah these will also have to be updated in the bump automation, I think it's not ideal
| return "", fmt.Errorf("generate init.gradle, error: %w", errAuthTokenNotProvided) | ||
| } | ||
|
|
||
| if len(endpointURL) < 1 { | ||
| if len(preferences.Cache.EndpointURL) < 1 && preferences.Cache.Usage == UsageLevelEnabled { |
There was a problem hiding this comment.
We should add the same check for analytics too, right?
There was a problem hiding this comment.
All the other endpoints are coming from consts, cache endpoint was overrideable from the CLI.
| EndpointURLWithPort string | ||
| IsPushEnabled bool | ||
| ValidationLevel string | ||
| Metadata common.CacheConfigMetadata |
There was a problem hiding this comment.
Should we move this to the top level? All plugins need the metadata
|
|
||
| bitrise { | ||
| {{- if .AppSlug }} | ||
| appSlug.set("{{ .AppSlug }}") |
There was a problem hiding this comment.
Why not in the metadata?
There was a problem hiding this comment.
Moving the metadata outside and making this part of it
No description provided.