[ACI-3782] Fetch bitrise plugins to local repository #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrekel
reviewed
Jun 12, 2025
There was a problem hiding this comment.
I don't really remember how we started to name (most but not all) the files in the project using camelCase, but it looks a bit strange (we use snake_case in go project). Nevertheless, let's not refactor the whole project :)
viktorbenei
reviewed
Jun 12, 2025
| return fmt.Errorf("read auth config from environment variables: %w", err) | ||
| } | ||
|
|
||
| kvClient, err := createKVClient(ctx, |
There was a problem hiding this comment.
Note: Bitrise CI KV Cache is only available on Bitrise CI currently.
imrekel
reviewed
Jun 12, 2025
| return fmt.Errorf("read auth config from environment variables: %w", err) | ||
| } | ||
|
|
||
| kvClient, err := createKVClient(ctx, |
There was a problem hiding this comment.
an idea for the future: let's call it createBuildCacheKVClient to distinguish it from the actual Key Value Cache service - which stores data in cloud storage)
imrekel
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch bitrise plugins to local repository when enabling gradle buildcache