Show step bundle title [BIVS-3405] #1648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook uploaded to: https://storybook.services.bitrise.dev/projects/wfe/pr-1648/ |
SummaryThis PR adds step bundle title display functionality. The changes extract logic into a new useStepBundleInstance hook and update StepBundleCard to display the step bundle's merged title or CVS ID fallback. A type safety issue and inconsistent null coalescing operators were identified. |
AndrasEszes
requested changes
Oct 20, 2025
There was a problem hiding this comment.
- useStepBundleInstance should return only the stepBundleInstance.
- prevent silent errors: if the instance isn't found based on the input parameters, the useStepBundleInstance hook should throw an error so DataDog can see it.
- please rename the useStepBundleInstance hook parameters... it's confusing how they're used in StepBundleCard.
- BONUS: I see some duplicated code in the hook. Maybe it can be simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.