Skip to content
Draft
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _integration_tests/zip/ipa_reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import (
"testing"

"github.com/bitrise-io/go-utils/v2/log"
"github.com/bitrise-io/go-xcode/plistutil"
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/_integration_tests"
"github.com/bitrise-io/go-xcode/v2/artifacts"
internalzip "github.com/bitrise-io/go-xcode/v2/internal/zip"
"github.com/bitrise-io/go-xcode/v2/plistutil"
"github.com/bitrise-io/go-xcode/v2/profileutil"
"github.com/bitrise-io/go-xcode/v2/zip"
"github.com/stretchr/testify/require"
)
Expand Down
2 changes: 1 addition & 1 deletion artifacts/ios_xcarchive_reader.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package artifacts

import (
"github.com/bitrise-io/go-xcode/plistutil"
"github.com/bitrise-io/go-xcode/v2/plistutil"
)

// IOSXCArchiveReader ...
Expand Down
4 changes: 2 additions & 2 deletions artifacts/ipa_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package artifacts
import (
"fmt"

"github.com/bitrise-io/go-xcode/plistutil"
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/plistutil"
"github.com/bitrise-io/go-xcode/v2/profileutil"
)

// IPAReader ...
Expand Down
2 changes: 1 addition & 1 deletion artifacts/xcarchive_reader.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package artifacts

import (
"github.com/bitrise-io/go-xcode/plistutil"
"github.com/bitrise-io/go-xcode/v2/plistutil"
)

// XCArchiveReader ...
Expand Down
4 changes: 2 additions & 2 deletions autocodesign/autocodesign.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import (
"math/big"

"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
"github.com/bitrise-io/go-xcode/v2/devportalservice"
"github.com/bitrise-io/go-xcode/v2/profileutil"
"github.com/bitrise-io/go-xcode/xcodeproject/serialized"
)

Expand Down
2 changes: 1 addition & 1 deletion autocodesign/autocodesign_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import (
"time"

"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
devportaltime "github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/time"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/certdownloader/certdownloader.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"github.com/bitrise-io/go-steputils/input"
"github.com/bitrise-io/go-utils/filedownloader"
"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
)

// CertificateAndPassphrase contains a p12 file URL and passphrase
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/certdownloader/certdownloader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"testing"
"time"

"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
"github.com/stretchr/testify/assert"
)

Expand Down
2 changes: 1 addition & 1 deletion autocodesign/certificates.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"strings"

"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
)

func selectCertificatesAndDistributionTypes(certificateSource DevPortalClient, typeToLocalCerts LocalCertificates, distribution DistributionType, signUITestTargets bool, verboseLog bool) (map[appstoreconnect.CertificateType][]Certificate, []DistributionType, error) {
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/certificates_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import (
"time"

"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
)
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/codesignasset/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import (

"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-utils/pathutil"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/autocodesign/keychain"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
)

const (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import (
"math/big"

"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
)

// CertificateSource ...
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/devportalclient/spaceship/certificates.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import (
"fmt"
"math/big"

"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
)

// CertificateSource ...
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/keychain/keychain.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"github.com/bitrise-io/go-utils/fileutil"
"github.com/bitrise-io/go-utils/pathutil"
"github.com/bitrise-io/go-utils/v2/command"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
"github.com/hashicorp/go-version"
)

Expand Down
2 changes: 1 addition & 1 deletion autocodesign/keychain/keychain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"github.com/bitrise-io/go-steputils/v2/stepconf"
"github.com/bitrise-io/go-utils/v2/command"
"github.com/bitrise-io/go-utils/v2/env"
"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
)

func TestCreateKeychain(t *testing.T) {
Expand Down
6 changes: 3 additions & 3 deletions autocodesign/localcodesignasset/localcodesignasset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import (

devportaltime "github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/time"

"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/exportoptions"
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/autocodesign/localcodesignasset/mocks"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
"github.com/bitrise-io/go-xcode/v2/exportoptions"
"github.com/bitrise-io/go-xcode/v2/profileutil"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
)
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion autocodesign/localcodesignasset/profile.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package localcodesignasset

import (
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/time"
"github.com/bitrise-io/go-xcode/v2/profileutil"
)

// Profile ...
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/localcodesignasset/profileconverter.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package localcodesignasset
import (
"os"

"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/profileutil"
)

// ProvisioningProfileConverter ...
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/localcodesignasset/profilelookup.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"time"

"github.com/bitrise-io/go-utils/sliceutil"
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/profileutil"
)

func findProfile(localProfiles []profileutil.ProvisioningProfileInfoModel, platform autocodesign.Platform, distributionType autocodesign.DistributionType, bundleID string, entitlements autocodesign.Entitlements, minProfileDaysValid int, certSerials []string, deviceUDIDs []string) *profileutil.ProvisioningProfileInfoModel {
Expand Down
6 changes: 3 additions & 3 deletions autocodesign/localcodesignasset/profilelookup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ package localcodesignasset
import (
"testing"

"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/exportoptions"
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
"github.com/bitrise-io/go-xcode/v2/exportoptions"
"github.com/bitrise-io/go-xcode/v2/profileutil"
"github.com/stretchr/testify/assert"
)

Expand Down
2 changes: 1 addition & 1 deletion autocodesign/localcodesignasset/profileprovider.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package localcodesignasset

import "github.com/bitrise-io/go-xcode/profileutil"
import "github.com/bitrise-io/go-xcode/v2/profileutil"

// ProvisioningProfileProvider can list profile infos.
type ProvisioningProfileProvider interface {
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/mock_AssetWriter.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion autocodesign/mock_CertificateProvider.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion autocodesign/profiledownloader/profiledownloader.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (

"github.com/bitrise-io/go-steputils/input"
"github.com/bitrise-io/go-utils/filedownloader"
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign"
"github.com/bitrise-io/go-xcode/v2/autocodesign/localcodesignasset"
"github.com/bitrise-io/go-xcode/v2/profileutil"
)

type downloader struct {
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/profiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-utils/retry"
"github.com/bitrise-io/go-utils/sliceutil"
"github.com/bitrise-io/go-xcode/profileutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/profileutil"
"github.com/bitrise-io/go-xcode/xcodeproject/serialized"
)

Expand Down
2 changes: 1 addition & 1 deletion autocodesign/projectmanager/projecthelper.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"regexp"
"strings"

"github.com/bitrise-io/go-plist"
"github.com/bitrise-io/go-utils/fileutil"
"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/go-utils/pathutil"
Expand All @@ -17,7 +18,6 @@ import (
"github.com/bitrise-io/go-xcode/xcodeproject/serialized"
"github.com/bitrise-io/go-xcode/xcodeproject/xcodeproj"
"github.com/bitrise-io/go-xcode/xcodeproject/xcscheme"
"howett.net/plist"
)

// ProjectHelper ...
Expand Down
2 changes: 1 addition & 1 deletion autocodesign/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ package autocodesign
import (
"testing"

"github.com/bitrise-io/go-xcode/certificateutil"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/appstoreconnect"
"github.com/bitrise-io/go-xcode/v2/autocodesign/devportalclient/time"
"github.com/bitrise-io/go-xcode/v2/certificateutil"
"github.com/stretchr/testify/assert"
)

Expand Down
58 changes: 58 additions & 0 deletions certificateutil/filter.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
package certificateutil

import "sort"

// FilterCertificateInfoModelsByFilterFunc ...
func FilterCertificateInfoModelsByFilterFunc(certificates []CertificateInfoModel, filterFunc func(certificate CertificateInfoModel) bool) []CertificateInfoModel {
filteredCertificates := []CertificateInfoModel{}

for _, certificate := range certificates {
if filterFunc(certificate) {
filteredCertificates = append(filteredCertificates, certificate)
}
}

return filteredCertificates
}

// ValidCertificateInfo contains the certificate infos filtered as valid, invalid and duplicated common name certificates
type ValidCertificateInfo struct {
ValidCertificates,
InvalidCertificates,
DuplicatedCertificates []CertificateInfoModel
}

// FilterValidCertificateInfos filters out invalid and duplicated common name certificaates
func FilterValidCertificateInfos(certificateInfos []CertificateInfoModel) ValidCertificateInfo {
var invalidCertificates []CertificateInfoModel
nameToCerts := map[string][]CertificateInfoModel{}
for _, certificateInfo := range certificateInfos {
if certificateInfo.CheckValidity() != nil {
invalidCertificates = append(invalidCertificates, certificateInfo)
continue
}

nameToCerts[certificateInfo.CommonName] = append(nameToCerts[certificateInfo.CommonName], certificateInfo)
}

var validCertificates, duplicatedCertificates []CertificateInfoModel
for _, certs := range nameToCerts {
if len(certs) == 0 {
continue
}

sort.Slice(certs, func(i, j int) bool {
return certs[i].EndDate.After(certs[j].EndDate)
})
validCertificates = append(validCertificates, certs[0])
if len(certs) > 1 {
duplicatedCertificates = append(duplicatedCertificates, certs[1:]...)
}
}

return ValidCertificateInfo{
ValidCertificates: validCertificates,
InvalidCertificates: invalidCertificates,
DuplicatedCertificates: duplicatedCertificates,
}
}
Loading
Loading