[CI-5225] Keep xcresult attachments in chronological order (#236)

* [CI-5225] Keep xcresult attachments in chronological order

* Update test/converters/xcresult3/converter.go

* fix: update converter tests

Author: AndrasEszes

test/converters/xcresult3/converter.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"path/filepath"
 	"runtime"
+	"sort"
 	"strconv"
 	"strings"
 	"sync"
@@ -283,7 +284,13 @@ func extractAttachments(xcresultPath, outputPath string) (map[string][]string, e
 
 	var fileCounterMap = make(map[string]int)
 	for _, attachmentDetail := range manifest {
-		for _, attachment := range attachmentDetail.Attachments {
+		attachments := attachmentDetail.Attachments
+
+		sort.Slice(attachments, func(i, j int) bool {
+			return time.Time(attachments[i].Timestamp).Before(time.Time(attachments[j].Timestamp))
+		})
+
+		for _, attachment := range attachments {
 			oldPath := filepath.Join(outputPath, attachment.ExportedFileName)
 			newPath := filepath.Join(outputPath, attachment.SuggestedHumanReadableName)
 

test/converters/xcresult3/converter_test.go

@@ -93,27 +93,27 @@ func TestConverter_XML(t *testing.T) {
 							Property: []testreport.Property{
 								{
 									Name:  "attachment_0",
-									Value: "Screenshot 2022-02-10 at 02.57.47 PM.jpeg",
+									Value: "Screenshot 2022-02-10 at 02.57.39 PM.jpeg",
 								},
 								{
 									Name:  "attachment_1",
-									Value: "Screenshot 2022-02-10 at 02.57.47 PM (1).jpeg",
+									Value: "Screenshot 2022-02-10 at 02.57.39 PM (1).jpeg",
 								},
 								{
 									Name:  "attachment_2",
-									Value: "Screenshot 2022-02-10 at 02.57.47 PM (2).jpeg",
+									Value: "Screenshot 2022-02-10 at 02.57.44 PM.jpeg",
 								},
 								{
 									Name:  "attachment_3",
-									Value: "Screenshot 2022-02-10 at 02.57.39 PM.jpeg",
+									Value: "Screenshot 2022-02-10 at 02.57.47 PM.jpeg",
 								},
 								{
 									Name:  "attachment_4",
-									Value: "Screenshot 2022-02-10 at 02.57.44 PM.jpeg",
+									Value: "Screenshot 2022-02-10 at 02.57.47 PM (1).jpeg",
 								},
 								{
 									Name:  "attachment_5",
-									Value: "Screenshot 2022-02-10 at 02.57.39 PM (1).jpeg",
+									Value: "Screenshot 2022-02-10 at 02.57.47 PM (2).jpeg",
 								},
 							},
 						},
@@ -176,11 +176,11 @@ func TestConverter_XML(t *testing.T) {
 							Property: []testreport.Property{
 								{
 									Name:  "attachment_0",
-									Value: "Screenshot 2021-02-09 at 08.35.52 AM.jpeg",
+									Value: "Screenshot 2021-02-09 at 08.35.51 AM.jpeg",
 								},
 								{
 									Name:  "attachment_1",
-									Value: "Screenshot 2021-02-09 at 08.35.51 AM.jpeg",
+									Value: "Screenshot 2021-02-09 at 08.35.52 AM.jpeg",
 								},
 								{
 									Name:  "attachment_2",