Skip to content

[PM-19107] Implement privileged app management for FIDO2 #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: innovation-sprint/privileged-apps/base
Choose a base branch
from

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

PM-19107

📔 Objective

Introduces the ability to trust privileged applications for FIDO2 operations.

If a calling application is acting as a privileged application but is not yet trusted, the user will be given the option to trust the app and continue the operation, or to cancel the operation without trusting the application. If the application is trusted, subsequent requests from the application will be treated as a trusted application without user interaction.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (ad6bc88) to head (9beb3ec).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           innovation-sprint/privileged-apps/base    #4848      +/-   ##
==========================================================================
- Coverage                                   89.49%   83.62%   -5.87%     
==========================================================================
  Files                                         499      623     +124     
  Lines                                       42507    48491    +5984     
  Branches                                     5985     6722     +737     
==========================================================================
+ Hits                                        38040    40551    +2511     
- Misses                                       2399     5668    +3269     
- Partials                                     2068     2272     +204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck force-pushed the innovation-sprint/privileged-apps/trust-dialog branch from 4c2645a to d587122 Compare March 11, 2025 20:08
Copy link
Contributor

github-actions bot commented Mar 11, 2025

Logo
Checkmarx One – Scan Summary & Details10cca9b8-e59b-42f8-be8b-a565d8e31256

Great job, no security vulnerabilities found in this Pull Request

@SaintPatrck SaintPatrck changed the base branch from main to innovation-sprint/privileged-apps/base March 11, 2025 20:09
@SaintPatrck SaintPatrck force-pushed the innovation-sprint/privileged-apps/trust-dialog branch 5 times, most recently from ac3ad3e to 465c5ce Compare March 13, 2025 19:41
Introduces the ability to trust privileged applications for FIDO2 operations.

If a calling application is acting as a privileged application but is not yet trusted, the user will be given the option to trust the app and continue the operation, or to cancel the operation without trusting the application. If the application is trusted, subsequent requests from the application will be treated as a trusted application without user interaction.
@SaintPatrck SaintPatrck force-pushed the innovation-sprint/privileged-apps/trust-dialog branch from 465c5ce to 9beb3ec Compare March 19, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant