[PM-24980] Send no PR feedback when clients build is missing #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprusik
commented
Aug 19, 2025
| - name: Set no PR feedback when missing build artifact | ||
| if: ${{ failure() && steps.get-build-artifact.conclusion == 'failure' }} | ||
| run: | | ||
| echo "send_pr_feedback=false" > "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
We already appended earlier, so replace instead here (we don't use GITHUB_OUTPUT anywhere else in the job, so this should be safe)
|
Great job! No new security vulnerabilities introduced in this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-24980
📔 Objective
Cut down on failure notices that aren't related to BIT testing outcomes. In these cases where the clients build isn't available, it's expected to be due to a timing issue (lots of rapid commits being pushed up) or some other blocking concern that implies a re-run of BIT in the immediate/relevant future.
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes