Transition to job matrix approach instead

Author: vvolkgang

.github/workflows/crowdin-pull.yml

@@ -8,8 +8,19 @@ on:
 
 jobs:
   crowdin-sync:
-    name: Crowdin Pull - ${{ github.event_name }}
+    name: Crowdin Pull - ${{ matrix.name }} - ${{ github.event_name }}
     runs-on: ubuntu-24.04
+    strategy:
+      matrix:
+        include:
+          - name: Password Manager
+            project_id: 269690
+            config: crowdin-pm.yml
+            branch: crowdin-pull-bwpm
+          - name: Authenticator
+            project_id: 673718
+            config: crowdin-bwa.yml
+            branch: crowdin-pull-bwa
     steps:
       - name: Checkout repo
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -38,52 +49,18 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
           CROWDIN_API_TOKEN: ${{ steps.retrieve-secrets.outputs.crowdin-api-token }}
-          _CROWDIN_PROJECT_ID: "269690"
+          _CROWDIN_PROJECT_ID: ${{ matrix.project_id }}
         with:
-          config: crowdin-pm.yml
+          config: ${{ matrix.config }}
           upload_sources: false
           upload_translations: false
           download_translations: true
           github_user_name: "bitwarden-devops-bot"
           github_user_email: "106330231+bitwarden-devops-bot@users.noreply.github.com"
           commit_message: "Pull translations from Crowdin"
-          localization_branch_name: crowdin-pull-bwpm
+          localization_branch_name: ${{ matrix.branch }}
           create_pull_request: true
-          pull_request_title: ":shipit: Crowdin Pull - Password Manager"
-          pull_request_body: ":inbox_tray: New translations for Password Manager received!"
+          pull_request_title: ":shipit: Crowdin Pull - ${{ matrix.name }}"
+          pull_request_body: ":inbox_tray: New translations for ${{ matrix.name }} received!"
           gpg_private_key: ${{ steps.retrieve-secrets.outputs.github-gpg-private-key }}
-          gpg_passphrase: ${{ steps.retrieve-secrets.outputs.github-gpg-private-key-passphrase }}
-
-      - name: Remove GPG Lock files
-        run: |
-          #ref: https://superuser.com/questions/1811518/gpg-stops-doing-anything-on-mac
-          #ref: https://forum.gnupg.org/t/gpg-stuck-after-any-command/4197/6
-
-          ls -l ~/.gnupg/*.lock
-          echo "-------"
-          ls -l ~/.gnupg/**/*.lock
-          echo "-------"
-          rm -rf ~/.gnupg/*.lock
-          rm -rf ~/.gnupg/public-keys.d/*.lock
-
-      - name: Download translations for Authenticator
-        uses: crowdin/github-action@b8012bd5491b8aa8578b73ab5b5f5e7c94aaa6e2 # v2.7.0
-        env:
-          GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
-          CROWDIN_API_TOKEN: ${{ steps.retrieve-secrets.outputs.crowdin-api-token }}
-          _CROWDIN_PROJECT_ID: "673718"
-        with:
-          config: crowdin-bwa.yml
-          upload_sources: false
-          upload_translations: false
-          download_translations: true
-          github_user_name: "bitwarden-devops-bot"
-          github_user_email: "106330231+bitwarden-devops-bot@users.noreply.github.com"
-          commit_message: "Pull translations from Crowdin"
-          localization_branch_name: crowdin-pull-bwa
-          create_pull_request: true
-          pull_request_title: ":shipit: Crowdin Pull - Authenticator"
-          pull_request_body: ":inbox_tray: New translations for Authenticator received!"
-          gpg_passphrase: ${{ steps.retrieve-secrets.outputs.github-gpg-private-key-passphrase }}
-          #NOTE - gpg_private_key ommited because they're setup by the previous step.
-          #       This step would fail if they were included again
+          gpg_passphrase: ${{ steps.retrieve-secrets.outputs.github-gpg-private-key-passphrase }}