generated from bitwarden/template
-
Notifications
You must be signed in to change notification settings - Fork 54
[PM-13428] Remove ownership option #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
64cec21
pm-13428 Add validation to check if user belongs to any org
LRNcardozoWDF 7589d70
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option-local
LRNcardozoWDF 49c5320
pm-13428 Add ui test
LRNcardozoWDF 1aa4586
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF 7d5ddb5
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF dc5f086
pm-13428 Add missing tests
LRNcardozoWDF 4d07dd7
pm-13428 Remove changes
LRNcardozoWDF ecfe06f
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF c3168a4
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF f9044cc
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF e174bd2
pm-13428 Fix PR comments
LRNcardozoWDF 447e703
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF c27b6cb
pm-13428 Add tests for hasOrganizations
LRNcardozoWDF 7a1732d
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF a32c0e7
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF 081d243
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF fc78ddf
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF 23b6d5d
pm-13428 Fix PR comments
LRNcardozoWDF b668b9d
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF 6940927
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF 979a3ab
pm-13428 Fix PR comment
LRNcardozoWDF 9f85d3a
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF 8e7977e
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF 2f9ec57
Merge branch 'main' into cmcg/pm-13428-remove-ownership-option
LRNcardozoWDF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-13.2 KB
(94%)
...em/AddEditItem/__Snapshots__/AddEditItemViewTests/test_snapshot_add_empty.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9.17 KB
(97%)
...pshots__/AddEditItemViewTests/test_snapshot_add_identity_full_fieldsEmpty.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.35 KB
(98%)
...shots__/AddEditItemViewTests/test_snapshot_add_identity_full_fieldsFilled.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-30.8 KB
(97%)
...dEditItemViewTests/test_snapshot_add_identity_full_fieldsFilled_largeText.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.71 KB
(97%)
...hots__/AddEditItemViewTests/test_snapshot_add_login_full_fieldsNotVisible.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.38 KB
(97%)
...apshots__/AddEditItemViewTests/test_snapshot_add_login_full_fieldsVisible.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4.51 KB
(97%)
...napshots__/AddEditItemViewTests/test_snapshot_add_personalOwnershipPolicy.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9.4 KB
(95%)
...ts__/AddEditItemViewTests/test_snapshot_add_secureNote_full_fieldsVisible.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
โ๏ธ Add tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, ty! Tests added c27b6cb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
โ๏ธ Nice! Could you add an additional test when
organizationId
isnil
andstate.ownershipOptions
is empty? It would be the intermediate state while the view is fetching the cipher options.