Skip to content

[BWA-155] refactor: Move TimeProvider to BitwardenKit #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-155

📔 Objective

To continue the process of moving the ConfigService into BitwardenKit, this moves the TimeProvider into BitwardenKit. It also brings the PreviewTimeProvider.

This is a separate PR because of the number of import statements involved, and I wanted to reduce noise.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented May 7, 2025

Logo
Checkmarx One – Scan Summary & Detailsbf32e1be-cae4-437d-9f6f-f0a875f6e0c6

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.00%. Comparing base (129973c) to head (6066cef).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ardenKit/Core/Platform/Services/TimeProvider.swift 66.66% 1 Missing ⚠️
...rm/Application/Utilities/PreviewTimeProvider.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
- Coverage   89.72%   86.00%   -3.73%     
==========================================
  Files         782      991     +209     
  Lines       49426    59644   +10218     
==========================================
+ Hits        44348    51295    +6947     
- Misses       5078     8349    +3271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode marked this pull request as ready for review May 7, 2025 20:40
@KatherineInCode KatherineInCode requested review from matt-livefront and a team as code owners May 7, 2025 20:40
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KatherineInCode KatherineInCode merged commit 0c65d99 into main May 8, 2025
12 checks passed
@KatherineInCode KatherineInCode deleted the bwa-155/time-provider-consolidation branch May 8, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants