-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-14613] Remove account deprovisioning feature flag #5676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14613] Remove account deprovisioning feature flag #5676
Conversation
New Issues (3)Checkmarx found the following issues in this Pull Request
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5676 +/- ##
==========================================
- Coverage 50.45% 47.24% -3.21%
==========================================
Files 1641 1641
Lines 74716 74566 -150
Branches 6737 6721 -16
==========================================
- Hits 37699 35230 -2469
- Misses 35486 37870 +2384
+ Partials 1531 1466 -65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Auth changes look good.
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…lag-removal---step-1-remove-flagged-logic-from-clients/server-and-clients-feature-flag
48c3e9c
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14613
📔 Objective
Remove the account deprovisioning feature flag.
Note that the definition is being retained to be served to old clients, however all old conditional logic can be cleaned up now.
Client PR which must be merged first: bitwarden/clients#14353
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes