Skip to content

[PM-14613] Remove account deprovisioning feature flag #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Apr 21, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14613

📔 Objective

Remove the account deprovisioning feature flag.

Note that the definition is being retained to be served to old clients, however all old conditional logic can be cleaned up now.

Client PR which must be merged first: bitwarden/clients#14353

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Apr 21, 2025

Logo
Checkmarx One – Scan Summary & Detailsca3bba88-fe2d-4d02-b086-38cd6c7a8af3

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 70
detailsMethod PostIpn at line 70 of /src/Billing/Controllers/PayPalController.cs gets a parameter from a user request from Body. This parameter value fl...
ID: 00txYX7J7xrof%2FuwKmvfZ50DJpE%3D
Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
detailsMethod Put at line 164 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter v...
ID: yt2PajNvte2IY7Xe%2FRtOPf8qKlo%3D
Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/Billing/TrialInitiationVerifyEmail.html.hbs: 5
detailsA Content Security Policy is not explicitly defined within the web-application.
ID: QypzWUzCL2qiFG6v23B59ISeF4g%3D
Attack Vector
Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Billing/Controllers/AccountsController.cs: 144
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 95
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 135
MEDIUM CSRF /src/Api/Vault/Controllers/SyncController.cs: 76

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 47.24%. Comparing base (15b4981) to head (2abc36e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...icies/PolicyValidators/SingleOrgPolicyValidator.cs 25.00% 0 Missing and 3 partials ⚠️
src/Admin/Controllers/UsersController.cs 0.00% 2 Missing ⚠️
...lidators/TwoFactorAuthenticationPolicyValidator.cs 33.33% 0 Missing and 2 partials ⚠️
...vices/Implementations/OrganizationDomainService.cs 0.00% 2 Missing ⚠️
...Api/AdminConsole/Controllers/PoliciesController.cs 0.00% 0 Missing and 1 partial ⚠️
src/Api/Vault/Controllers/CiphersController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5676      +/-   ##
==========================================
- Coverage   50.45%   47.24%   -3.21%     
==========================================
  Files        1641     1641              
  Lines       74716    74566     -150     
  Branches     6737     6721      -16     
==========================================
- Hits        37699    35230    -2469     
- Misses      35486    37870    +2384     
+ Partials     1531     1466      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

eliykat added 4 commits April 22, 2025 09:20
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
@eliykat eliykat marked this pull request as ready for review May 4, 2025 23:47
@eliykat eliykat requested review from a team as code owners May 4, 2025 23:47
Jingo88
Jingo88 previously approved these changes May 6, 2025
eliykat added 2 commits May 7, 2025 07:07
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…move-flagged-logic-from-clients/server-and-clients-feature-flag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Auth changes look good.

eliykat and others added 2 commits May 9, 2025 10:33
…move-flagged-logic-from-clients/server-and-clients-feature-flag
…lag-removal---step-1-remove-flagged-logic-from-clients/server-and-clients-feature-flag
Copy link

sonarqubecloud bot commented May 11, 2025

@eliykat eliykat merged commit a1b22e6 into main May 12, 2025
53 checks passed
@eliykat eliykat deleted the ac/pm-14613/feature-flag-removal---step-1-remove-flagged-logic-from-clients/server-and-clients-feature-flag branch May 12, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants