Skip to content

[PM-19016] Allow for deletion of pending providers #5679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19016

📔 Objective

Quick fix to allow for the deletion of providers in a pending status.

📸 Screenshots

Pending (New)

Screen.Recording.2025-04-21.at.1.15.04.PM.mov

Billable (Existing)

Screen.Recording.2025-04-21.at.1.15.56.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner April 21, 2025 17:18
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2a458297-2963-4484-a847-0d45900e589d

New Issues (4)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
detailsMethod Put at line 164 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter val...
ID: O%2BHxUDVmhn4DDWQtZQFQAhiT9ZY%3D
Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 96
detailsMethod Patch at line 96 of /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs gets a parameter from a user request from model. This par...
ID: qOrS%2Bmn6Gg1L4tTtOw7xqc0462I%3D
Attack Vector
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 86
detailsMethod Put at line 86 of /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs gets a parameter from a user request from model. This param...
ID: tdBhFufVwEv2BYlT6X8qz8sKXeo%3D
Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
detailsMethod Put at line 133 of /src/Api/AdminConsole/Public/Controllers/GroupsController.cs gets a parameter from a user request from model. This parame...
ID: En5BEJJONHFvKUkaerwROu5tjB0%3D
Attack Vector
Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationSponsorshipsController.cs: 46
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 76

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 46.85%. Comparing base (b38c752) to head (78a9a31).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...in/AdminConsole/Controllers/ProvidersController.cs 0.00% 8 Missing ⚠️
src/Admin/AdminConsole/Views/Providers/Edit.cshtml 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5679      +/-   ##
==========================================
- Coverage   46.85%   46.85%   -0.01%     
==========================================
  Files        1615     1615              
  Lines       73587    73596       +9     
  Branches     6622     6625       +3     
==========================================
  Hits        34482    34482              
- Misses      37660    37669       +9     
  Partials     1445     1445              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amorask-bitwarden amorask-bitwarden merged commit 00b9ba2 into main Apr 28, 2025
53 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/PM-19016/delete-provider-pending-status branch April 28, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants