[PM-17562] Add feature flag for event-based organization integrations #5710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent of flag at the API layer
…n on/off event queue
LaunchDarkly flag references🔍 1 flag added or modified
|
|
New Issues (4)Checkmarx found the following issues in this Pull Request
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5710 +/- ##
==========================================
- Coverage 47.20% 47.19% -0.01%
==========================================
Files 1633 1633
Lines 74165 74184 +19
Branches 6676 6678 +2
==========================================
+ Hits 35008 35014 +6
- Misses 37706 37719 +13
Partials 1451 1451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
withinfocus
previously approved these changes
Apr 25, 2025
|
withinfocus
approved these changes
Apr 25, 2025
r-tome
approved these changes
Apr 28, 2025
brant-livefront
deleted the
brant/PM-17562-feature-flag-for-event-integrations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17562
📔 Objective
This PR adds a feature flag for event-based organization integrations that allows the queuing to be turned on/off. When the feature flag is disabled, the events should be written as they were previously (i.e. to the Azure queue in cloud, or the Repository in self-hosted). In addition, the API around creating/updating/deleting integrations and integration configurations will simply return 404s. When the feature flag is enabled and the queue is configured, it will write to the RabbitMQ or Azure service bus queues, which also enables all the integrations to be run.
Without the feature flag in place, we had to configure either the repository or the event queue. The goal of this PR is to have both the previous model and the event queues configured and ready to go. The feature flag can then allow us to toggle between the two if there's anything that we need to address without having to restart things to un-configure the event queues.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes