ci: lint, format and test in github actions #18
Conversation
| name: Lint and Format | ||
| on: | ||
| pull_request: | ||
| pull_request_target: |
There was a problem hiding this comment.
This is actually safer to use when dealing with forked repos apparently https://dev.to/suzukishunsuke/secure-github-actions-by-pullrequesttarget-641
|
|
||
| it('should return true if feedUri includes admin_did for the "custom" service', async () => { | ||
| // TODO: Mocks need to be adjusted, some tests are still hitting the database instead of being mocked | ||
| it.skip('should return true if feedUri includes admin_did for the "custom" service', async () => { |
There was a problem hiding this comment.
One of the tests that were failing due to the mocks not working. Still couldn't figure out why it was still failing after I got the mocks in place but can be looked at in a different PR
| runs-on: ubuntu-latest | ||
| env: | ||
| PGUSER: postgres | ||
| PGPASSWORD: password |
There was a problem hiding this comment.
wasn't sure how secrets worked with forked repos but we can probably figure this out and move this to a secret
package.json
Outdated
| "prepare": "husky install", | ||
| "migrate:create": "knex migrate:make", | ||
| "migrate:up": "knex migrate:latest", | ||
| "migrate:up": "NODE_OPTIONS='--import tsx/esm' knex migrate:latest", |
There was a problem hiding this comment.
ESM problems :( though the good thing with this is that we can use this for the dev script too
|
@FreedomWriter conflicts should be fixed 🫡 good to go |
…ormatting-linting-ci
…-skies-api into feat/formatting-linting-ci
2 participants
Description
This PR adds 2 workflow files to the codebase. Would merge #17 first before this one so I can pull those changes in and update this PR accordingly
I haven't really decided how much we should move from the pre-commit hooks to github actions, should discuss before merging. I also noticed that for some tests the mocks need to be adjusted, some of them that are supposed to be mocked are still hitting the database but that can be addressed in a separate PR
Related Issues
Resolves #16
Changes Made
2 new workflow files: linting/formatting + tests
How to Test
Try pushing a commit to this PR
Checklist
Before submitting your PR, ensure you’ve completed the following:
npm run lintand resolved any warnings/errors.Additional Notes
I did remove ts-node-dev in favour of tsx to resolve some ESM issues I was having with knex so this might require an npm install