Fix inline views not refreshing #2580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention: Possibly also affects calendar view |
ShadiestGoat
force-pushed
the
fix-inline-refresh
branch
from
da8fe02 to
143862d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, inline queries do not get periodically refreshed due to a bug in implementation of the refresher class. This PR should address that
Related issues: #1317 & #2340
This PR addresses both issues, though with concerns over performance & wishes for more targeted & instant refreshing (eg. "Oh we are querying
this.field? Lets refresh whenthis.fieldchanges`)