MDL-76190: Draft #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfederico
force-pushed
the
MDL-76190
branch
4 times, most recently
from
0bbae92 to
d6fa456
Compare
Where the same report exists multiple times on the page, ensure we are still able to uniquely identify each via ID. Update the filters module to ensure the filters form for each report is initialised.
This ensures that we always dispatch the dynamic table updated event against the same table we just updated. Previously it was possible for another table to receive the event, where both tables were effectively the same instance of one another (e.g. custom reports).
jfederico
force-pushed
the
MDL-76190
branch
3 times, most recently
from
eae0c5b to
affd7ab
Compare
This reverts the changes to core/element-group by MDL-61823 as it is causing duplicate ID issues.
* Return early if the `userids` params is empty or if the filtered user IDs end up being empty.
jfederico
force-pushed
the
MDL-76190
branch
2 times, most recently
from
9d5a9e1 to
9b426a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** PLEASE DO NOT OPEN PULL REQUESTS VIA GITHUB ***
The moodle.git repository at Github is just a mirror of the official repository. We do not accept pull requests at Github.
See CONTRIBUTING.md guidelines for how to contribute patches for Moodle. Thank you.
--