Add Detailed Debugging to query latency #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If debugging is turned on dump the raw values from performance_schema.events_statements_histogram_global | ||
| if blip.Debugging { | ||
| blip.Debug("Bucket Number|Bucket Timer Low|Bucket Timer High|Count Bucket|Count Bucket and Lower|Bucket Quantile") | ||
| rows, err := c.db.QueryContext(ctx, "SELECT * FROM performance_schema.events_statements_histogram_global") |
Contributor
There was a problem hiding this comment.
Probably best to order by what Blip will actually see/use, then also handle logging timestamps, i.e. the fact that logs will have virtually same ts means they'll order randomly in DD, so we won't be able to see the real order of rows. Maybe emit just 1 big log event to bypass all log ordering (and possibly log filtering)?
Collaborator
Author
There was a problem hiding this comment.
I think that it will get split by newline even if I combine it, though that may fix the ordering issue. I'll test it out and see what happens.
Collaborator
Author
There was a problem hiding this comment.
Updated. Output from a single large string is broken up but the ordering is preserved.
daniel-nichter
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.