Skip to content

add server-side logging for db errors #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

add server-side logging for db errors #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8732aa6
add server-side logging for db errors
qian-squareup Jun 10, 2025
e3c35e0
update error message in api wrapper
qian-squareup Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/api_gomux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,6 +1178,7 @@ func (api *API) readError(rc *req, w http.ResponseWriter, err error) {
api.systemMetrics.Inc(metrics.Error, 1)
var httpStatus = http.StatusInternalServerError
var ret interface{}
log.Printf("API READ ERROR: %v", err)
switch v := err.(type) {
case etre.Error:
maybeInc(metrics.ClientError, 1, rc.gm)
Expand All @@ -1204,7 +1205,6 @@ func (api *API) readError(rc *req, w http.ResponseWriter, err error) {
if dbErr.Err == context.DeadlineExceeded {
maybeInc(metrics.QueryTimeout, 1, rc.gm)
} else {
log.Printf("DATABASE ERROR: %v", dbErr)
maybeInc(metrics.DbError, 1, rc.gm)
}
ret = etre.Error{
Expand All @@ -1215,7 +1215,6 @@ func (api *API) readError(rc *req, w http.ResponseWriter, err error) {
}
httpStatus = http.StatusServiceUnavailable
default:
log.Printf("API ERROR: %v", err)
maybeInc(metrics.APIError, 1, rc.gm)
httpStatus = http.StatusInternalServerError
}
Expand All @@ -1234,6 +1233,7 @@ func (api *API) WriteResult(rc *req, w http.ResponseWriter, ids interface{}, err

// Map error to etre.Error
if err != nil {
log.Printf("API WRITE ERROR: %v", err)
api.systemMetrics.Inc(metrics.Error, 1)
switch v := err.(type) {
case etre.Error:
Expand Down