Fix RuboCop issues

Author: Mattia Roccoberton

.rubocop.yml

@@ -18,27 +18,9 @@ AllCops:
     - vendor/**/*
   NewCops: enable
 
-Gemspec/RequiredRubyVersion:
-  Enabled: false
-
-Naming/FileName:
-  Enabled: false
-
-Layout/LineLength:
-  Enabled: true
-  Max: 120
+Style/OpenStructUse:
+  Enabled: false # TODO: fix me
 
 RSpec/ExampleLength:
-  Max: 8
-
-RSpec/MultipleExpectations:
-  Max: 5
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true
+  # default 5
+  Max: 10

spec/system/authors_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe 'Authors', type: :system do
-  it 'fails to create an author', :vcr do
+  it 'fails to create an author', :aggregate_failures, :vcr do
     visit '/admin/authors/new'
 
     fill_in('author[name]', with: 'Boh')
@@ -13,7 +13,7 @@
     expect(error).to include 'Invalid email'
   end
 
-  it 'creates an author', :vcr do
+  it 'creates an author', :aggregate_failures, :vcr do
     visit '/admin/authors/new'
 
     fill_in('author[name]', with: 'Some name')
@@ -26,21 +26,21 @@
   end
 
   context 'with some authors' do
-    it 'loads the authors list', :vcr do
+    it 'loads the authors list', :aggregate_failures, :vcr do
       visit '/admin/authors'
 
       expect(page).to have_http_status(:success)
       expect(page).to have_css('#index_table_authors td.col-name', count: 4)
     end
 
-    it 'loads an author', :vcr do
+    it 'loads an author', :aggregate_failures, :vcr do
       visit '/admin/authors/1'
 
       expect(page).to have_http_status(:success)
       expect(page).to have_css('#attributes_table_author_1')
     end
 
-    it 'fails to update an author', :vcr do
+    it 'fails to update an author', :aggregate_failures, :vcr do
       visit '/admin/authors/1/edit'
 
       fill_in('author[name]', with: '')
@@ -51,7 +51,7 @@
       expect(error).to include "is too short"
     end
 
-    it 'updates an author', :vcr do
+    it 'updates an author', :aggregate_failures, :vcr do
       visit '/admin/authors/1/edit'
 
       fill_in('author[age]', with: '30')
@@ -61,7 +61,7 @@
       expect(page).to have_content('Author was successfully updated.')
     end
 
-    it 'destroys an author', :vcr do
+    it 'destroys an author', :aggregate_failures, :vcr do
       visit '/admin/authors'
 
       find_all('.delete_link.member_link').last.click

spec/system/posts_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe 'Posts', type: :system do
-  it 'fails to create a post', :vcr do
+  it 'fails to create a post', :aggregate_failures, :vcr do
     visit '/admin/posts/new'
 
     fill_in('post[title]', with: '')
@@ -13,7 +13,7 @@
   end
 
   context 'with some authors' do
-    it 'creates a post', :vcr do
+    it 'creates a post', :aggregate_failures, :vcr do
       visit '/admin/posts/new'
 
       fill_in('post[title]', with: 'Some title')
@@ -26,21 +26,21 @@
   end
 
   context 'with some posts' do
-    it 'loads the posts list', :vcr do
+    it 'loads the posts list', :aggregate_failures, :vcr do
       visit '/admin/posts'
 
       expect(page).to have_http_status(:success)
       expect(page).to have_css('#index_table_posts td.col-title', count: 3)
     end
 
-    it 'loads a post', :vcr do
+    it 'loads a post', :aggregate_failures, :vcr do
       visit '/admin/posts/1'
 
       expect(page).to have_http_status(:success)
       expect(page).to have_css('#attributes_table_post_1')
     end
 
-    it 'fails to update a post', :vcr do
+    it 'fails to update a post', :aggregate_failures, :vcr do
       visit '/admin/posts/1/edit'
 
       fill_in('post[title]', with: '')
@@ -51,7 +51,7 @@
       expect(error).to include "is too short"
     end
 
-    it 'updates a post', :vcr do
+    it 'updates a post', :aggregate_failures, :vcr do
       visit '/admin/posts/1/edit'
 
       fill_in('post[description]', with: 'Some desc')
@@ -61,7 +61,7 @@
       expect(page).to have_content('Post was successfully updated.')
     end
 
-    it 'destroys a post', :vcr do
+    it 'destroys a post', :aggregate_failures, :vcr do
       visit '/admin/posts'
 
       find_all('.delete_link.member_link').last.click

spec/system/tags_spec.rb

@@ -2,14 +2,14 @@
 
 RSpec.describe 'Tags', type: :system do
   context 'with some tags' do
-    it 'loads the tags list', :vcr do
+    it 'loads the tags list', :aggregate_failures, :vcr do
       visit '/admin/tags'
 
       expect(page).to have_http_status(:success)
       expect(page).to have_css('#index_table_tags td.col-name', count: 5)
     end
 
-    it 'filters the tags', :vcr do
+    it 'filters the tags', :aggregate_failures, :vcr do
       visit '/admin/tags'
 
       fill_in('q[name_cont]', with: 'Some tag')
@@ -19,7 +19,7 @@
       expect(name.text).to eq 'Some tag'
     end
 
-    it 'loads a tag', :vcr do
+    it 'loads a tag', :aggregate_failures, :vcr do
       visit '/admin/tags/1'
 
       expect(page).to have_http_status(:success)