refactor: add gas refund tracking to journal and host interfaces #2877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `record_refund`, `refund`, and `reset_refund` methods in the `JournalTr` trait to manage gas refunds at the journal level. - Updated the `Host` trait to include a `record_refund` method for recording gas refunds. - Implemented the corresponding methods in `DummyHost` and `JournalInner`. - Adjusted gas handling in various components to ensure refunds are recorded correctly, adhering to EIP-3529 limits. - Refactored related functions in the handler and interpreter to utilize the new refund tracking system.
CodSpeed Performance ReportMerging #2877 will not alter performanceComparing Summary
|
rakita
reviewed
Aug 11, 2025
rakita
reviewed
Aug 11, 2025
| /// refund values being visible during individual call frame execution. | ||
| #[inline] | ||
| pub fn record_refund(&mut self, refund: i64) { | ||
| self.refund += refund; |
There was a problem hiding this comment.
Journal entry for refund should be made so refund can be reverted in case of revert/oog/stackoverflow etc.
There was a problem hiding this comment.
case of revert/oog/stackoverflow etc.
Look like these aren't covered by test.
…g/stackoverflow etc.
|
This looks okay now, will see to merge it a little bit later so it does not affect downstream inspectors in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2145
record_refund,refund, andreset_refundmethods in theJournalTrtrait to manage gas refunds at the journal level.Hosttrait to include arecord_refundmethod for recording gas refunds.DummyHostandJournalInner.