-
Notifications
You must be signed in to change notification settings - Fork 811
Feature: Support bubbling up Precompile error messages #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Support bubbling up Precompile error messages #2905
Conversation
CodSpeed Performance ReportMerging #2905 will degrade performances by 3.18%Comparing Summary
Benchmarks breakdown
|
3c7b3b0
to
832dba9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a different approach for this. Only place where we can return the error outside of evm is if transaction target points to the precompile.
We should introduce the mechanism that if depth == 0 and precompile returns the error for this error to be saved in Context and returned in output
d64fe87
to
52b1122
Compare
987e937
to
feba95d
Compare
feba95d
to
0e07129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits left, otherwise lgtm
Motivation
This PR enhances precompile error reporting and closes #2898.
Solution
Attempt to implement a mechanism that records potential precompile error in context if depth == 0, in order to bubble it up in output as Bytes. Idea proposed by Rakita #2905 (review).
TODO