Skip to content

Conversation

mablr
Copy link
Contributor

@mablr mablr commented Aug 20, 2025

Motivation

This PR enhances precompile error reporting and closes #2898.

Solution

Attempt to implement a mechanism that records potential precompile error in context if depth == 0, in order to bubble it up in output as Bytes. Idea proposed by Rakita #2905 (review).

TODO

  • make tests
  • doc

Copy link

codspeed-hq bot commented Aug 20, 2025

CodSpeed Performance Report

Merging #2905 will degrade performances by 3.18%

Comparing mablr:feature/precompileerror-value-variant-without-copy-trait (0b4d66c) with main (0e05a30)

Summary

❌ 1 regression
✅ 172 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
transfer_finalize 15.1 µs 15.6 µs -3.18%

@mablr mablr marked this pull request as draft August 21, 2025 15:38
@mablr mablr force-pushed the feature/precompileerror-value-variant-without-copy-trait branch 2 times, most recently from 3c7b3b0 to 832dba9 Compare August 21, 2025 16:50
@mablr mablr marked this pull request as ready for review August 21, 2025 17:13
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a different approach for this. Only place where we can return the error outside of evm is if transaction target points to the precompile.

We should introduce the mechanism that if depth == 0 and precompile returns the error for this error to be saved in Context and returned in output

@mablr mablr marked this pull request as draft August 26, 2025 22:02
@mablr mablr closed this Aug 27, 2025
@mablr mablr force-pushed the feature/precompileerror-value-variant-without-copy-trait branch from d64fe87 to 52b1122 Compare August 27, 2025 20:23
@mablr mablr reopened this Aug 27, 2025
@mablr mablr force-pushed the feature/precompileerror-value-variant-without-copy-trait branch from 987e937 to feba95d Compare August 28, 2025 21:38
@mablr mablr force-pushed the feature/precompileerror-value-variant-without-copy-trait branch from feba95d to 0e07129 Compare August 28, 2025 21:40
@mablr mablr marked this pull request as ready for review August 28, 2025 21:48
@mablr mablr requested a review from rakita August 28, 2025 21:49
@rakita rakita self-requested a review September 26, 2025 13:16
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits left, otherwise lgtm

@rakita rakita merged commit b7cb54f into bluealloy:main Sep 28, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support bubbling up Precompile error messages
2 participants