Skip to content

Conversation

rakita
Copy link
Member

@rakita rakita commented Sep 24, 2025

Closes #2984

InspectorEvmTr now depends on InspectorFrame and not on EthFrame

Copy link

codspeed-hq bot commented Sep 24, 2025

CodSpeed Performance Report

Merging #3009 will degrade performances by 3.15%

Comparing rakita/cframe (d636407) with main (0e05a30)

Summary

❌ 2 regressions
✅ 171 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
NUMBER_50 17.2 µs 17.7 µs -3.1%
SELFBALANCE_50 19.4 µs 20 µs -3.15%

pub trait InspectorEvmTr:
EvmTr<
Frame = EthFrame<EthInterpreter>,
Frame: InspectorFrameTr<IT = EthInterpreter>,
Copy link
Member Author

@rakita rakita Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes dependency on EthFrame and introduces InspectorFrameTr that has fn eth_frame() -> Option<&EthFrame>. cc @klkvr @mattsse

@rakita rakita changed the title feat: Custom frame example and decoupling from revm feat: Flush out usage of custom frame, example in MyEvm Sep 25, 2025
@rakita rakita marked this pull request as ready for review September 25, 2025 11:54
@rakita rakita requested review from mattsse and klkvr September 25, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flush out usage of custom frame, make an example
1 participant