Skip to content

Conversation

futreall
Copy link
Contributor

Replace duplicate BENCH_TARGET_BALANCE and BENCH_CALLER_BALANCE constants with a shared COMMON_TEST_BALANCE constant to improve maintainability.

Both constants had identical values: U256::from_limbs([10_000_000_000_000_000, 0, 0, 0])

This change:

  • Eliminates code duplication
  • Makes balance changes easier to maintain
  • Preserves all existing functionality
  • Only affects test/benchmark constants

Copy link

codspeed-hq bot commented Sep 27, 2025

CodSpeed Performance Report

Merging #3017 will not alter performance

Comparing futreall:refactor/extract-common-test-balance (27dc07a) with main (b7cb54f)

Summary

✅ 173 untouched

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pending

futreall and others added 3 commits September 28, 2025 17:15
Co-authored-by: rakita <rakita@users.noreply.github.com>
Co-authored-by: rakita <rakita@users.noreply.github.com>
Co-authored-by: rakita <rakita@users.noreply.github.com>
@futreall
Copy link
Contributor Author

thanks!

@rakita
Copy link
Member

rakita commented Sep 29, 2025

tests fixed on main

@rakita rakita merged commit 299cefd into bluealloy:main Sep 29, 2025
27 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants