Use compio for completion-based async operation #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antifuchs
changed the title
antifuchs
force-pushed
the
push-kzqntwomqwzz
branch
5 times, most recently
from
1640a23 to
047f970
Compare
|
OK, this looks about 2x as slow on linux than the naive-most sync implementation, which is both kind of a surprise and ... not? I'm not happy that the silly sync impl is apparently our perf ceiling but ok. |
antifuchs
force-pushed
the
push-kzqntwomqwzz
branch
8 times, most recently
from
e10c780 to
ec34c2e
Compare
Unfortunately, its AsyncRead/AsyncWrite trait isn't implemented by fs::File, which means it isn't compatible with its own io::copy function. That's not fantastic.
io::copy isn't *that* smart, and it is less unclear to understand what's going on if we manage buffers ourselves. Let's do that, and maybe gain a little flexibility in the future too.
antifuchs
force-pushed
the
push-kzqntwomqwzz
branch
from
ec34c2e to
6e30bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this can be faster.
In any case, this PR restructures the code such that it becomes somewhat clearer what's going on:
io::copyto compare data on disk with what "should" be there, instead implementing the comparison loop ourselves.