Merge pull request #68 from boolean-uk/67-hotfix---fix-register-no-need-to-validate-username

Refactor request DTO

Author: otvegg

exercise.tests/Helpers/UserTestCases.cs

@@ -14,8 +14,6 @@ public static IEnumerable<TestCaseData> ValidRegisterCases()
 
         public static IEnumerable<TestCaseData> InvalidRegisterCases()
         {
-            yield return new TestCaseData("ThisIsWayTooLong123ThisIsWayTooLong123ThisIsWayTooLong123", "valid@email.com", "ValidPass1!").SetName("Invalid: Username too long (register)");
-            yield return new TestCaseData("", "valid@email.com", "ValidPass1!").SetName("Invalid: Username too short (register)");
             yield return new TestCaseData("validuser", "plainaddress", "ValidPass1!").SetName("Invalid: Invalid email format (register)");
             yield return new TestCaseData("validuser", "user@domain.c", "ValidPass1!").SetName("Invalid: Invalid email domain (register)");
             yield return new TestCaseData("validuser", "valid@email.com", "short1!").SetName("Invalid: Password too short (register)");

exercise.tests/IntegrationTests/UserTests.cs

@@ -43,11 +43,6 @@ public async Task Register_success(string username, string email, string passwor
 
             RegisterRequestDTO body = new RegisterRequestDTO {
                 email = $"{uniqueId}{email}",
-                firstName = "Ole",
-                lastName = "Petterson",
-                bio = "Min bio er vakker",
-                githubUsername = uniqueUsername,
-                username = uniqueUsername,
                 password = password
             };
             var json = JsonSerializer.Serialize(body);
@@ -80,11 +75,6 @@ public async Task Register_Failure(string username, string email, string passwor
             RegisterRequestDTO body = new RegisterRequestDTO
             {
                 email = $"{uniqueId}{email}",
-                firstName = firstName,
-                lastName = lastName,
-                bio = "Min bio er vakker",
-                githubUsername = uniqueUsername,
-                username =uniqueUsername,
                 password = password
             };
 

exercise.wwwapi/DTOs/Register/RegisterRequestDTO.cs

@@ -7,10 +7,5 @@ public class RegisterRequestDTO
     {
         public required string email { get; set; }
         public required string password { get; set; }
-        public string? firstName { get; set; }
-        public string? lastName { get; set; }
-        public string? bio { get; set; }
-        public string? githubUsername { get; set; }
-        public string? username { get; set; } 
     }
 }

exercise.wwwapi/Endpoints/UserEndpoints.cs

@@ -61,11 +61,7 @@ private static IResult Register(RegisterRequestDTO request, IRepository<User> se
             // check valid email
             string emailValidation = Validator.Email(request.email);
             if (emailValidation != "Accepted") return TypedResults.BadRequest(new ResponseDTO<Object>() { Message = emailValidation });
-            // check valid username
-            string usernameValidation = Validator.Username(request.username);
-            if (usernameValidation != "Accepted") return TypedResults.BadRequest(new ResponseDTO<Object>() { Message = usernameValidation });
 
-            // ecxist checks
             // check if email is in database
             var emailExists = service.GetAllFiltered(q => q.Email == request.email);
             if (emailExists.Count() != 0) return Results.Conflict(new ResponseDTO<Object>() { Message = "Fail" });
@@ -75,13 +71,8 @@ private static IResult Register(RegisterRequestDTO request, IRepository<User> se
 
             var user = new User();
 
-            user.Username = !string.IsNullOrEmpty(request.username) ? request.username : request.email;
             user.PasswordHash = passwordHash;
             user.Email = request.email; 
-            user.FirstName = !string.IsNullOrEmpty(request.firstName) ? request.firstName : string.Empty;
-            user.LastName = !string.IsNullOrEmpty(request.lastName) ? request.lastName : string.Empty;
-            user.Bio = !string.IsNullOrEmpty(request.bio) ? request.bio : string.Empty;
-            user.GithubUsername = !string.IsNullOrEmpty(request.githubUsername) ? request.githubUsername : string.Empty;
 
             service.Insert(user);
             service.Save();